Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ObsUx] Add actions column with link to discover for Inventory #199025

Closed
jennypavlova opened this issue Nov 5, 2024 · 1 comment · Fixed by #199306
Closed

[ObsUx] Add actions column with link to discover for Inventory #199025

jennypavlova opened this issue Nov 5, 2024 · 1 comment · Fixed by #199306
Assignees
@jennypavlova
Labels
enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@jennypavlova
Copy link
Member

jennypavlova commented Nov 5, 2024 •
edited
Loading

Summary

We want to add a link to Discover inside the table for every entity as an action
Image

Investigation

There is already a button component that navigates to discover in the search - should check if it can be reused or share common parts. What I see as a difference here is that we need to pass an identifier for every entity to do the filtering (eg service.name, host.name, container.id, etc.) to make sure that once the user sees the Discover page the filters are applied

AC

  • The actions column is present in the inventory table
  • The actions menu shows one item: a link with the text 'Open in Discover'
  • The results in Discover should be filtered by entity
@jennypavlova jennypavlova added enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 5, 2024
@jennypavlova jennypavlova self-assigned this Nov 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@jennypavlova jennypavlova mentioned this issue Nov 7, 2024
Merged
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 11, 2024
@jennypavlova @kibanamachine @CAWilson94
[ObsUx][Inventory] Add actions column with link to discover for inven…
27a97a1 
…tory (elastic#199306)

Closes elastic#199025 
## Summary

This PR adds an actions column with a link to discover for inventory. It
is available in the inventory grid(s) in both the group view and the
unified inventory view.

The column header tooltip text will change when it's available:
[issue](elastic#199500) added

⚠️ If the discover link is not available I added a logic to hide the
whole actions column as this is the only available option for now. Once
we add more actions we should refactor that to just not add the action
and to keep the column visible (which doesn't make sense atm)

## Testing
- Enable the Inventory
- Check with/without grouping both the action link and the button
   - combination of kuery / drop-down filter
   - without any filters
   - With just one kuery or drop-down filter 
- When the link is clicked from the table we should see a filter by
identity field in the query in discover (like `service.name: 'test'`,
`conteainer.id: 'test'`)
  


https://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e



https://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318

---------

Co-authored-by: kibanamachine <[email protected]>
cauemarcondes pushed a commit to cauemarcondes/kibana that referenced this issue Nov 12, 2024
@jennypavlova
[ObsUx][Inventory] Add actions column with link to discover for inven…
1268d01 
…tory (elastic#199306)

Closes elastic#199025
## Summary

This PR adds an actions column with a link to discover for inventory. It
is available in the inventory grid(s) in both the group view and the
unified inventory view.

The column header tooltip text will change when it's available:
[issue](elastic#199500) added

⚠️ If the discover link is not available I added a logic to hide the
whole actions column as this is the only available option for now. Once
we add more actions we should refactor that to just not add the action
and to keep the column visible (which doesn't make sense atm)

## Testing
- Enable the Inventory
- Check with/without grouping both the action link and the button
   - combination of kuery / drop-down filter
   - without any filters
   - With just one kuery or drop-down filter
- When the link is clicked from the table we should see a filter by
identity field in the query in discover (like `service.name: 'test'`,
`conteainer.id: 'test'`)

https://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e

https://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit fcc3b06)
cauemarcondes added a commit that referenced this issue Nov 12, 2024
@cauemarcondes @jennypavlova
[8.x] [ObsUx][Inventory] Add actions column with link to discover for…
94bde2c 
… inventory (#199306) (#199789)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ObsUx][Inventory] Add actions column with link to discover for
inventory (#199306)](#199306)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-08T18:18:07Z","message":"[ObsUx][Inventory]
Add actions column with link to discover for inventory
(#199306)\n\nCloses #199025 \r\n## Summary\r\n\r\nThis PR adds an
actions column with a link to discover for inventory. It\r\nis available
in the inventory grid(s) in both the group view and the\r\nunified
inventory view.\r\n\r\nThe column header tooltip text will change when
it's
available:\r\n[issue](#199500)
added\r\n\r\n⚠️ If the discover link is not available I added a logic to
hide the\r\nwhole actions column as this is the only available option
for now. Once\r\nwe add more actions we should refactor that to just not
add the action\r\nand to keep the column visible (which doesn't make
sense atm)\r\n\r\n## Testing\r\n- Enable the Inventory\r\n- Check
with/without grouping both the action link and the button\r\n -
combination of kuery / drop-down filter\r\n - without any filters\r\n -
With just one kuery or drop-down filter \r\n- When the link is clicked
from the table we should see a filter by\r\nidentity field in the query
in discover (like `service.name: 'test'`,\r\n`conteainer.id:
'test'`)\r\n
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"fcc3b0654525d67d34cc5916b4b6f7351892f650","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services"],"number":199306,"url":"https://github.com/elastic/kibana/pull/199306","mergeCommit":{"message":"[ObsUx][Inventory]
Add actions column with link to discover for inventory
(#199306)\n\nCloses #199025 \r\n## Summary\r\n\r\nThis PR adds an
actions column with a link to discover for inventory. It\r\nis available
in the inventory grid(s) in both the group view and the\r\nunified
inventory view.\r\n\r\nThe column header tooltip text will change when
it's
available:\r\n[issue](#199500)
added\r\n\r\n⚠️ If the discover link is not available I added a logic to
hide the\r\nwhole actions column as this is the only available option
for now. Once\r\nwe add more actions we should refactor that to just not
add the action\r\nand to keep the column visible (which doesn't make
sense atm)\r\n\r\n## Testing\r\n- Enable the Inventory\r\n- Check
with/without grouping both the action link and the button\r\n -
combination of kuery / drop-down filter\r\n - without any filters\r\n -
With just one kuery or drop-down filter \r\n- When the link is clicked
from the table we should see a filter by\r\nidentity field in the query
in discover (like `service.name: 'test'`,\r\n`conteainer.id:
'test'`)\r\n
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"fcc3b0654525d67d34cc5916b4b6f7351892f650"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199306","number":199306,"mergeCommit":{"message":"[ObsUx][Inventory]
Add actions column with link to discover for inventory
(#199306)\n\nCloses #199025 \r\n## Summary\r\n\r\nThis PR adds an
actions column with a link to discover for inventory. It\r\nis available
in the inventory grid(s) in both the group view and the\r\nunified
inventory view.\r\n\r\nThe column header tooltip text will change when
it's
available:\r\n[issue](#199500)
added\r\n\r\n⚠️ If the discover link is not available I added a logic to
hide the\r\nwhole actions column as this is the only available option
for now. Once\r\nwe add more actions we should refactor that to just not
add the action\r\nand to keep the column visible (which doesn't make
sense atm)\r\n\r\n## Testing\r\n- Enable the Inventory\r\n- Check
with/without grouping both the action link and the button\r\n -
combination of kuery / drop-down filter\r\n - without any filters\r\n -
With just one kuery or drop-down filter \r\n- When the link is clicked
from the table we should see a filter by\r\nidentity field in the query
in discover (like `service.name: 'test'`,\r\n`conteainer.id:
'test'`)\r\n
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/bb4a89f5-2b30-457f-bf13-7580ff162a7e\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2894ef5c-6622-4488-ab84-c453f5b6e318\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"fcc3b0654525d67d34cc5916b4b6f7351892f650"}}]}]
BACKPORT-->

Co-authored-by: jennypavlova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennypavlova jennypavlova

Labels
enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ObsUx][Inventory] Add actions column with link to discover for inventory jennypavlova/kibana
2 participants
@jennypavlova @elasticmachine