Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Migrate /test/apm_api_integration/tests/services to be deployment-agnostic API tests #198988

Closed
rmyz opened this issue Nov 5, 2024 · 0 comments · Fixed by #199812 or #200196
Closed
Assignees
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture

Comments

@rmyz
Copy link
Contributor

rmyz commented Nov 5, 2024

API ESS Serverless Test files
GET /internal/apm/services/{serviceName}/agent ESS: ./test/apm_api_integration/tests/services/agent.spec.ts
POST /api/apm/services/{serviceName}/annotation ESS: ./test/apm_api_integration/tests/services/annotations.spec.ts
POST /internal/apm/services/detailed_statistics ESS: ./test/apm_api_integration/tests/services/archive_services_detailed_statistics.spec.ts
GET /api/apm/services/{serviceName}/annotation/search ESS: ./test/apm_api_integration/tests/services/derived_annotations.spec.ts
POST /internal/apm/services/{serviceName}/errors/groups/detailed_statistics ESS: ./test/apm_api_integration/tests/services/error_groups/error_groups_detailed_statistics.spec.ts
GET /internal/apm/services/{serviceName}/errors/groups/main_statistics ESS: ./test/apm_api_integration/tests/services/error_groups/error_groups_main_statistics.spec.ts
GET /internal/apm/services/{serviceName}/node/{serviceNodeName}/metadata ESS: ./test/apm_api_integration/tests/services/get_service_node_metadata.spec.ts
GET /internal/apm/services/{serviceName}/alerts_count ESS: ./test/apm_api_integration/tests/services/service_alerts.spec.ts
GET /internal/apm/services/{serviceName}/metadata/details ESS: ./test/apm_api_integration/tests/services/service_details/service_details.spec.ts
GET /internal/apm/services/{serviceName}/service_overview_instances/details/{serviceNodeName} ESS: ./test/apm_api_integration/tests/services/service_details/service_infra_metrics.spec.ts
GET /internal/apm/services/{serviceName}/metadata/icons ESS: ./test/apm_api_integration/tests/services/service_icons/service_icons.spec.ts
POST /internal/apm/services/detailed_statistics ESS: ./test/apm_api_integration/tests/services/services_detailed_statistics.spec.ts
GET /internal/apm/services/{serviceName}/throughput ESS: ./test/apm_api_integration/tests/services/throughput.spec.ts
GET /internal/apm/services ESS: ./test/apm_api_integration/tests/services/top_services.spec.ts
GET /internal/apm/services/{serviceName}/transaction_types ESS: ./test/apm_api_integration/tests/services/transaction_types.spec.ts
@rmyz rmyz added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture labels Nov 5, 2024
@crespocarlos crespocarlos self-assigned this Nov 7, 2024
crespocarlos added a commit that referenced this issue Nov 14, 2024
## Summary

Closes #198988
Part of #193245

This PR contains the changes to migrate `service` test folder to
Deployment-agnostic testing strategy.

>[!NOTE]
> `top_services.spec.ts` and `throughput.spec.ts` were partially
migrated and `annotations.spec.ts` was not migrated

### How to test

- Serverless

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```

It's recommended to be run against
[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)

- Stateful
```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```

- [ ] ~(OPTIONAL, only if a test has been unskipped) Run flaky test
suite~
- [x] local run for serverless
- [x] local run for stateful
- [x] MKI run for serverless

---------

Co-authored-by: Sergi Romeu <[email protected]>
crespocarlos added a commit to crespocarlos/kibana that referenced this issue Nov 14, 2024
## Summary

Closes elastic#198988
Part of elastic#193245

This PR contains the changes to migrate `service` test folder to
Deployment-agnostic testing strategy.

>[!NOTE]
> `top_services.spec.ts` and `throughput.spec.ts` were partially
migrated and `annotations.spec.ts` was not migrated

### How to test

- Serverless

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```

It's recommended to be run against
[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)

- Stateful
```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```

- [ ] ~(OPTIONAL, only if a test has been unskipped) Run flaky test
suite~
- [x] local run for serverless
- [x] local run for stateful
- [x] MKI run for serverless

---------

Co-authored-by: Sergi Romeu <[email protected]>
(cherry picked from commit 2e9926d)

# Conflicts:
#	x-pack/test/apm_api_integration/tests/services/agent.spec.ts
@crespocarlos crespocarlos reopened this Nov 14, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 18, 2024
## Summary

Closes elastic#198988
Part of elastic#193245

This PR contains the changes to migrate `service` test folder to
Deployment-agnostic testing strategy.

>[!NOTE]
> `top_services.spec.ts` and `throughput.spec.ts` were partially
migrated and `annotations.spec.ts` was not migrated

### How to test

- Serverless

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```

It's recommended to be run against
[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)

- Stateful
```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```

- [ ] ~(OPTIONAL, only if a test has been unskipped) Run flaky test
suite~
- [x] local run for serverless
- [x] local run for stateful
- [x] MKI run for serverless

---------

Co-authored-by: Sergi Romeu <[email protected]>
crespocarlos added a commit that referenced this issue Nov 18, 2024
Closes #198988
Part of #193245

## Summary

Follow up from #199812. The
`agent.spec.ts` test was deleted by mistake.

### How to test

- Serverless

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```

It's recommended to be run against
[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)

- Stateful
```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```

- [ ] ~(OPTIONAL, only if a test has been unskipped) Run flaky test
suite~
- [x] local run for serverless
- [x] local run for stateful
- [x] MKI run for serverless

---------

Co-authored-by: kibanamachine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 18, 2024
Closes elastic#198988
Part of elastic#193245

## Summary

Follow up from elastic#199812. The
`agent.spec.ts` test was deleted by mistake.

### How to test

- Serverless

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```

It's recommended to be run against
[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)

- Stateful
```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```

- [ ] ~(OPTIONAL, only if a test has been unskipped) Run flaky test
suite~
- [x] local run for serverless
- [x] local run for stateful
- [x] MKI run for serverless

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit c473a69)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 18, 2024
## Summary

Closes elastic#198988
Part of elastic#193245

This PR contains the changes to migrate `service` test folder to
Deployment-agnostic testing strategy.

>[!NOTE]
> `top_services.spec.ts` and `throughput.spec.ts` were partially
migrated and `annotations.spec.ts` was not migrated

### How to test

- Serverless

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```

It's recommended to be run against
[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)

- Stateful
```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```

- [ ] ~(OPTIONAL, only if a test has been unskipped) Run flaky test
suite~
- [x] local run for serverless
- [x] local run for stateful
- [x] MKI run for serverless

---------

Co-authored-by: Sergi Romeu <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
Closes elastic#198988
Part of elastic#193245

## Summary

Follow up from elastic#199812. The
`agent.spec.ts` test was deleted by mistake.

### How to test

- Serverless

```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM"
```

It's recommended to be run against
[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)

- Stateful
```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM"
```

- [ ] ~(OPTIONAL, only if a test has been unskipped) Run flaky test
suite~
- [x] local run for serverless
- [x] local run for stateful
- [x] MKI run for serverless

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
2 participants