Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Enable draggable headers in Timeline Unified Data table. #198955

Open
logeekal opened this issue Nov 5, 2024 · 3 comments
Open
Labels
enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Threat Hunting:Investigations Security Solution Investigations Team triage_needed

Comments

@logeekal
Copy link
Contributor

logeekal commented Nov 5, 2024

Summary

Recently EUIDataGrid and UnifiedDataTable implemented the capability to enable reordering of columns by dragging them. See #197832.

As per discussion here, when draggability of headers is enabled, All of the columns header operations such as Move left, Remove column, Copy Column stop working.

Image

We need to see why this is happening since it is standard EUI feature. If there are changes needed in Security solution to make it compatible, it should be looked into.

@logeekal logeekal added the enhancement New value added to drive a business result label Nov 5, 2024
@logeekal logeekal added this to the 8.17 milestone Nov 5, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 5, 2024
@logeekal logeekal changed the title [Security Solution] Enable draggable headers in Timeline EuiDataGrid table. [Security Solution] Enable draggable headers in Timeline Unified Data table. Nov 5, 2024
@logeekal logeekal added the Team:Threat Hunting:Investigations Security Solution Investigations Team label Nov 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 5, 2024
@logeekal logeekal removed this from the 8.17 milestone Nov 5, 2024
@logeekal logeekal added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Nov 5, 2024
@davismcphee
Copy link
Contributor

@logeekal I looked into this a bit more and it seems at least part of this (the actions menu) is actually a bug in EUI when EuiDataGrid is rendered within EuiModal. I created an issue for it here: elastic/eui#8119.

I wasn't able to reproduce the issue where dragging the headers doesn't work at all directly in EUI, but it's possible these issues still might be related.

@logeekal
Copy link
Contributor Author

logeekal commented Nov 6, 2024

Thank you @davismcphee. this is a great find. We also have Timeline Integration tests which run as e2e test just for timeline component and does not render Timeline in a modal and all tests pass there.

describe('columns', () => {
it(
'should move column left/right correctly ',
async () => {
const { container } = renderTestComponents();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Threat Hunting:Investigations Security Solution Investigations Team triage_needed
Projects
None yet
Development

No branches or pull requests

4 participants