[Discover] Remove field popover stats for ES|QL mode #198948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
release_note:skip
…eld-popover' into 198896-remove-esql-stats-from-field-popover
jughosta
added
the
Feature:UnifiedFieldList
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
davismcphee
approved these changes
Nov 8, 2024
|
Starting backport for target branches: 8.x |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
cc @jughosta |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 8, 2024
- Related to elastic#197538 ## Summary This PR removes the support of showing stats in the field popover in ES|QL mode as this UX will be revisited in the future to provide better results. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jughosta
added a commit
to jughosta/kibana
that referenced
this pull request
Nov 8, 2024
- Related to elastic#197538 ## Summary This PR removes the support of showing stats in the field popover in ES|QL mode as this UX will be revisited in the future to provide better results. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit e883ac5) # Conflicts: # test/functional/apps/discover/group6/_sidebar_field_stats.ts
jughosta
added a commit
that referenced
this pull request
Nov 8, 2024
…199472) # Backport This will backport the following commits from `main` to `8.x`: - [[Discover] Remove field popover stats for ES|QL mode (#198948)](#198948) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-08T11:04:47Z","message":"[Discover] Remove field popover stats for ES|QL mode (#198948)\n\n- Related to https://github.com/elastic/kibana/pull/197538\r\n\r\n## Summary\r\n\r\nThis PR removes the support of showing stats in the field popover in\r\nES|QL mode as this UX will be revisited in the future to provide better\r\nresults.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"e883ac5470352196252e300454e72b6d53696bda","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","Feature:UnifiedFieldList","Feature:ES|QL","Project:OneDiscover"],"number":198948,"url":"https://github.com/elastic/kibana/pull/198948","mergeCommit":{"message":"[Discover] Remove field popover stats for ES|QL mode (#198948)\n\n- Related to https://github.com/elastic/kibana/pull/197538\r\n\r\n## Summary\r\n\r\nThis PR removes the support of showing stats in the field popover in\r\nES|QL mode as this UX will be revisited in the future to provide better\r\nresults.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"e883ac5470352196252e300454e72b6d53696bda"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198948","number":198948,"mergeCommit":{"message":"[Discover] Remove field popover stats for ES|QL mode (#198948)\n\n- Related to https://github.com/elastic/kibana/pull/197538\r\n\r\n## Summary\r\n\r\nThis PR removes the support of showing stats in the field popover in\r\nES|QL mode as this UX will be revisited in the future to provide better\r\nresults.\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"e883ac5470352196252e300454e72b6d53696bda"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the support of showing stats in the field popover in ES|QL mode as this UX will be revisited in the future to provide better results.
Checklist