Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboards] Hovering over a panel when any control popover open causes hover and panel actions to superimpose on comtrols weirdly #198875

Open
bhavyarm opened this issue Nov 4, 2024 · 7 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Nov 4, 2024

Kibana version: main/serverless-qa

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from QA

Describe the bug: Hover and panel actions superimpose on controls if controls popover is open.

Steps to reproduce:

  1. Add a couple of controls to dashboard (can be both range and options controls)
  2. Add a couple of panels to dashboard
  3. Click on the control so either the options list or slider for range is open
  4. Hover over the panel below control
  5. The hover and panel actions for the panel are on top of the controls.

Image

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibanamachine kibanamachine added loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Nov 4, 2024
@mbondyra
Copy link
Contributor

mbondyra commented Nov 6, 2024

One more example with unified search bar:
Image

@Heenawter
Copy link
Contributor

Heenawter commented Nov 6, 2024

These are all to be expected. I think we could close this, since we need the hover actions to overlap the sticky section of the dashboard, and I don't think we want to hide them on scroll because this could be annoying. What do you think @cqliu1 @andreadelrio?

@cqliu1
Copy link
Contributor

cqliu1 commented Nov 6, 2024

We should consider fixing #197897 as well when tackling this UI bug.

@andreadelrio
Copy link
Contributor

My recommendation is the following:

Image

Image

Not sure about the code implications but UX wise I think this would get us a clean behavior.

@Heenawter
Copy link
Contributor

Heenawter commented Nov 6, 2024

Seems like we can implement @andreadelrio's suggestion with something like this: https://css-tricks.com/styling-based-on-scroll-position/ (and the code complexity is minimal)

@nreese
Copy link
Contributor

nreese commented Nov 7, 2024

@andreadelrio

I like your suggestion of putting the hover actions below the dashboard tool bar when scrolling.

@cqliu1 cqliu1 self-assigned this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

8 participants