[APM] Foundation for migrating APM tests to deployment agnostic approach #198775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crespocarlos
force-pushed
the
193245-apm-deployment-agnostic-tests-part-1
branch
9 times, most recently
from
2393507 to
5277183
Compare
Migrate agent_explorer test Update latest_agent_versions test
crespocarlos
force-pushed
the
193245-apm-deployment-agnostic-tests-part-1
branch
from
5277183 to
eee7cd3
Compare
|
/ci |
|
/ci |
crespocarlos
changed the title
|
/ci |
|
@elasticmachine merge upstream |
|
/ci |
|
@crespocarlos can you please add in the description how to run these tests. 🙏 |
Will do when I open the PR for review :) |
crespocarlos
added
release_note:skip
dmlemeshko
reviewed
Nov 6, 2024
...tion/deployment_agnostic/apis/observability/apm/agent_explorer/latest_agent_versions.spec.ts
Show resolved
Hide resolved
...integration/deployment_agnostic/apis/observability/apm/agent_explorer/agent_explorer.spec.ts
Show resolved
Hide resolved
| // Skipping here will skip the entire apm api test suite | ||
| // Instead skip (flaky) tests individually | ||
| // Failing: See https://github.com/elastic/kibana/issues/176948 | ||
| describe('APM API tests', function () { |
There was a problem hiding this comment.
Totally up to you about the naming, just since it is located in x-pack/test/api_integration you can probably omit API word.
x-pack/test/api_integration/deployment_agnostic/services/apm_api.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/deployment_agnostic/services/apm_api.ts
Outdated
Show resolved
Hide resolved
3 tasks
dmlemeshko
reviewed
Nov 6, 2024
...tion/deployment_agnostic/apis/observability/apm/agent_explorer/latest_agent_versions.spec.ts
Show resolved
Hide resolved
|
|
@elasticmachine merge upstream |
dmlemeshko
approved these changes
Nov 6, 2024
💚 Build Succeeded
Metrics [docs]
History
|
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
Nov 7, 2024
…ach (elastic#198775) part of elastic#193245 closes elastic#198958 ## Summary This PR lays the foundation to start migrating APM API integration tests to the deployment agnostic approach. ### How to test - Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM API tests" ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) - Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM API tests" ``` --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
crespocarlos
added a commit
to crespocarlos/kibana
that referenced
this pull request
Nov 11, 2024
…ach (elastic#198775) part of elastic#193245 closes elastic#198958 ## Summary This PR lays the foundation to start migrating APM API integration tests to the deployment agnostic approach. ### How to test - Serverless ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="APM API tests" ``` It's recommended to be run against [MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki) - Stateful ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="APM API tests" ``` --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 926861b)
crespocarlos
added a commit
that referenced
this pull request
Nov 11, 2024
… approach (#198775) (#199637) # Backport This will backport the following commits from `main` to `8.x`: - [[APM] Foundation for migrating APM tests to deployment agnostic approach (#198775)](#198775) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T16:38:17Z","message":"[APM] Foundation for migrating APM tests to deployment agnostic approach (#198775)\n\npart of https://github.com/elastic/kibana/issues/193245\r\ncloses https://github.com/elastic/kibana/issues/198958\r\n\r\n## Summary\r\n\r\nThis PR lays the foundation to start migrating APM API integration tests\r\nto the deployment agnostic approach.\r\n\r\n\r\n### How to test\r\n\r\n- Serverless\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep=\"APM API tests\"\r\n```\r\n\r\nIt's recommended to be run against\r\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\r\n\r\n- Stateful\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep=\"APM API tests\"\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"926861bcbce9a775eda7a389acedf935612b5985","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"number":198775,"url":"https://github.com/elastic/kibana/pull/198775","mergeCommit":{"message":"[APM] Foundation for migrating APM tests to deployment agnostic approach (#198775)\n\npart of https://github.com/elastic/kibana/issues/193245\r\ncloses https://github.com/elastic/kibana/issues/198958\r\n\r\n## Summary\r\n\r\nThis PR lays the foundation to start migrating APM API integration tests\r\nto the deployment agnostic approach.\r\n\r\n\r\n### How to test\r\n\r\n- Serverless\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep=\"APM API tests\"\r\n```\r\n\r\nIt's recommended to be run against\r\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\r\n\r\n- Stateful\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep=\"APM API tests\"\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"926861bcbce9a775eda7a389acedf935612b5985"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198775","number":198775,"mergeCommit":{"message":"[APM] Foundation for migrating APM tests to deployment agnostic approach (#198775)\n\npart of https://github.com/elastic/kibana/issues/193245\r\ncloses https://github.com/elastic/kibana/issues/198958\r\n\r\n## Summary\r\n\r\nThis PR lays the foundation to start migrating APM API integration tests\r\nto the deployment agnostic approach.\r\n\r\n\r\n### How to test\r\n\r\n- Serverless\r\n\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep=\"APM API tests\"\r\n```\r\n\r\nIt's recommended to be run against\r\n[MKI](https://github.com/crespocarlos/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki)\r\n\r\n- Stateful\r\n```\r\nnode scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts\r\nnode scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep=\"APM API tests\"\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"926861bcbce9a775eda7a389acedf935612b5985"}}]}] BACKPORT-->
kibanamachine
added
v8.17.0
and removed
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #193245
closes #198958
Summary
This PR lays the foundation to start migrating APM API integration tests to the deployment agnostic approach.
How to test
It's recommended to be run against MKI