Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Filter editor doesn't allow adding top-level boolean conditions when all top-level conditions have sub-conditions #198745

Open
smokris opened this issue Nov 3, 2024 · 2 comments
Labels
Feature:Unified search Unified search related tasks Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@smokris
Copy link

smokris commented Nov 3, 2024

Steps to reproduce

  • In Discover, click the Add filter button
  • Click the OR button
    • There are now 2 top-level boolean-or conditions, good
  • On each condition, click the AND button

The structured filter editor panel now looks like this:

Discover filter editor with 2 top-level boolean-or conditions, each having 2 boolean-and conditions

At this point, I'd like to add another top-level boolean-or condition, but the only way to do that is to delete one of the existing sub-conditions. (It's simple enough to delete and re-create empty conditions, but imagine I have already created a complex set of conditions with many is one of options selected — deleting and recreating that would be tedious.)

Proposed solution

Add a button to create another top-level condition of the same type as the existing top-level conditions:

proposed button to add top-level condition

Clicking that button would add another top-level condition:

result of pressing proposed button
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 3, 2024
@wayneseymour wayneseymour added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Nov 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 4, 2024
@kertal kertal added Feature:Unified search Unified search related tasks Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@kertal kertal removed the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Unified search Unified search related tasks Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants