[Inventory] Fix discover link #198690
Merged
[Inventory] Fix discover link #198690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kpatticha
commented
Nov 1, 2024
| const discoverLink = discoverLocator?.getRedirectUrl({ | ||
| indexPatternId: dataView?.id ?? '', | ||
| columns: ACTIVE_COLUMNS, | ||
| query: { query: kuery ?? '', language: 'kuery' }, | ||
| query: { query: kueryWithEntityDefinitionFilters, language: 'kuery' }, |
There was a problem hiding this comment.
Note
I pass it as a kuery cause the filter doesn't support pattern linke *
kpatticha
added
backport:prev-minor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 1, 2024
## Summary closes elastic#198533 - filter `builtin*` - add simple e2e (cherry picked from commit bc80825)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 1, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Inventory] Fix discover link (#198690)](#198690) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Katerina","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-01T20:21:11Z","message":"[Inventory] Fix discover link (#198690)\n\n## Summary\r\n\r\ncloses #198533 \r\n\r\n- filter `builtin*`\r\n- add simple e2e","sha":"bc80825cd89029282bfbdd17a916392d99663fa0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.17.0"],"title":"[Inventory] Fix discover link","number":198690,"url":"https://github.com/elastic/kibana/pull/198690","mergeCommit":{"message":"[Inventory] Fix discover link (#198690)\n\n## Summary\r\n\r\ncloses #198533 \r\n\r\n- filter `builtin*`\r\n- add simple e2e","sha":"bc80825cd89029282bfbdd17a916392d99663fa0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198690","number":198690,"mergeCommit":{"message":"[Inventory] Fix discover link (#198690)\n\n## Summary\r\n\r\ncloses #198533 \r\n\r\n- filter `builtin*`\r\n- add simple e2e","sha":"bc80825cd89029282bfbdd17a916392d99663fa0"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Katerina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #198533
builtin*