Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/server-route-repository] Clean up partial implementations #198681

Open
miltonhultgren opened this issue Nov 1, 2024 · 2 comments
Open

[kbn/server-route-repository] Clean up partial implementations #198681

miltonhultgren opened this issue Nov 1, 2024 · 2 comments
Labels
Team:obs-knowledge Observability Experience Knowledge team

Comments

@miltonhultgren
Copy link
Contributor

miltonhultgren commented Nov 1, 2024

Because the route repository package has evolved overtime and adoption has been continuous during that time, we can find some plugins that use some parts of functionality coming from the package and some parts that are "copies" of code that now has been ported into the package.

To ensure consistent usage of the package, we should refactor any plugin that uses the package but doesn't pull all the functionality from the package itself.

This may require extensions to the package in case there are additional features in the copies that have not been included in the package.

Affected plugins

  • apm (duplicate of createRepositoryClient, duplicate of registerRoutes) [@elastic/obs-ux-infra_services-team]
  • dataset_quality (duplicate of createRepositoryClient, duplicate of registerRoutes) [@elastic/obs-ux-logs-team]
  • investigate_app (duplicate of createRepositoryClient) [@elastic/obs-ux-management-team]
  • observability (duplicate of registerRoutes, doesn't create a client) [@elastic/obs-ux-management-team]
  • observability_onboarding (duplicate of createRepositoryClient, duplicate of registerRoutes) [@elastic/obs-ux-logs-team, @elastic/obs-ux-onboarding-team]
  • slo (duplicate of registerRoutes, doesn't create a client) [@elastic/obs-ux-management-team]
  • ux (duplicate of createRepositoryClient to talk to an APM API) [@elastic/obs-ux-infra_services-team]
@miltonhultgren miltonhultgren added the Team:obs-knowledge Observability Experience Knowledge team label Nov 1, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-knowledge-team (Team:obs-knowledge)

@miltonhultgren
Copy link
Contributor Author

miltonhultgren commented Nov 1, 2024

FYI @elastic/obs-ux-infra_services-team @elastic/obs-ux-logs-team @elastic/obs-ux-management-team @elastic/obs-ux-onboarding-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-knowledge Observability Experience Knowledge team
Projects
None yet
Development

No branches or pull requests

2 participants