Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Index Management] Support for index.mode in index template creation #198620

Closed
bitzandeb opened this issue Oct 31, 2024 · 1 comment · Fixed by #199521
Closed

[Index Management] Support for index.mode in index template creation #198620

bitzandeb opened this issue Oct 31, 2024 · 1 comment · Fixed by #199521
Assignees
@ElenaStoeva
Labels
enhancement New value added to drive a business result Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Milestone
8.17

Comments

@bitzandeb
Copy link

bitzandeb commented Oct 31, 2024 •
edited
Loading

In support of LogsDB going GA, we should support selecting an index mode as a part of data stream configuration via index templates within Kibana.

Includes the following:

  • Adding a new configuration setting to the logistics step of index templates called "Data stream index mode" that is exposed when the data stream toggle is enabled.
  • Any index template that has data streams enabled should also have an associated index mode selected
  • Setting the default should be Standard index mode, unless the index pattern specified is logs-*-* in which case the index mode should default to LogsDB
  • Adjusting the toggle for Data retention by moving it to the right

Index mode selection in Kibana should be available for both stateful and serverless deployments/projects, and all license types.

Screenshot example:

Image
@bitzandeb bitzandeb added enhancement New value added to drive a business result Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Oct 31, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@alisonelizabeth alisonelizabeth added this to the 8.17 milestone Nov 11, 2024
@ElenaStoeva ElenaStoeva mentioned this issue Nov 12, 2024
Merged
6 tasks
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 14, 2024
@ElenaStoeva
[Index Management] Add index mode field in index template form (elast…
7b25b66 
…ic#199521)

Closes elastic#198620

## Summary

This PR adds a field for index mode setting in the Logistics step in
Index Template form.

https://github.com/user-attachments/assets/ee38bdec-66ff-468d-a55e-abf5354c3da2

**How to test:**
1. Go to Index Management -> Index Templates and start creating an index
template
2. Verify that the index mode is only enabled if the data stream toggle
is on.
3. Verify that typing the `logs-*-*` index pattern sets the index mode
to "LogsDB":

<img width="1401" alt="Screenshot 2024-11-13 at 13 00 10"
src="https://github.com/user-attachments/assets/d1825d08-5039-4c43-80a8-653233e0b677">

4. Go to the Settings step and verify that the index mode callout is
displayed correctly.
5. Go to Review step and verify that Index mode is displayed correctly
in both the summary and the preview request.
6. Save the template and verify that the template details tab correctly
displays the index mode.

<img width="1565" alt="Screenshot 2024-11-13 at 17 22 54"
src="https://github.com/user-attachments/assets/2055501b-32c9-463c-b61d-541b9687b459">

<img width="1565" alt="Screenshot 2024-11-13 at 17 22 31"
src="https://github.com/user-attachments/assets/21c9cf9e-5858-4403-9106-57ed8ccf3639">

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

(cherry picked from commit 16127fc)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 18, 2024
@ElenaStoeva @CAWilson94
[Index Management] Add index mode field in index template form (elast…
8a18d0f 
…ic#199521)

Closes elastic#198620

## Summary

This PR adds a field for index mode setting in the Logistics step in
Index Template form.



https://github.com/user-attachments/assets/ee38bdec-66ff-468d-a55e-abf5354c3da2


**How to test:**
1. Go to Index Management -> Index Templates and start creating an index
template
2. Verify that the index mode is only enabled if the data stream toggle
is on.
3. Verify that typing the `logs-*-*` index pattern sets the index mode
to "LogsDB":

<img width="1401" alt="Screenshot 2024-11-13 at 13 00 10"
src="https://github.com/user-attachments/assets/d1825d08-5039-4c43-80a8-653233e0b677">



4. Go to the Settings step and verify that the index mode callout is
displayed correctly.
5. Go to Review step and verify that Index mode is displayed correctly
in both the summary and the preview request.
6. Save the template and verify that the template details tab correctly
displays the index mode.

<img width="1565" alt="Screenshot 2024-11-13 at 17 22 54"
src="https://github.com/user-attachments/assets/2055501b-32c9-463c-b61d-541b9687b459">

<img width="1565" alt="Screenshot 2024-11-13 at 17 22 31"
src="https://github.com/user-attachments/assets/21c9cf9e-5858-4403-9106-57ed8ccf3639">





### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Nov 18, 2024
@ElenaStoeva @CAWilson94
[Index Management] Add index mode field in index template form (elast…
0d0d0a9 
…ic#199521)

Closes elastic#198620

## Summary

This PR adds a field for index mode setting in the Logistics step in
Index Template form.



https://github.com/user-attachments/assets/ee38bdec-66ff-468d-a55e-abf5354c3da2


**How to test:**
1. Go to Index Management -> Index Templates and start creating an index
template
2. Verify that the index mode is only enabled if the data stream toggle
is on.
3. Verify that typing the `logs-*-*` index pattern sets the index mode
to "LogsDB":

<img width="1401" alt="Screenshot 2024-11-13 at 13 00 10"
src="https://github.com/user-attachments/assets/d1825d08-5039-4c43-80a8-653233e0b677">



4. Go to the Settings step and verify that the index mode callout is
displayed correctly.
5. Go to Review step and verify that Index mode is displayed correctly
in both the summary and the preview request.
6. Save the template and verify that the template details tab correctly
displays the index mode.

<img width="1565" alt="Screenshot 2024-11-13 at 17 22 54"
src="https://github.com/user-attachments/assets/2055501b-32c9-463c-b61d-541b9687b459">

<img width="1565" alt="Screenshot 2024-11-13 at 17 22 31"
src="https://github.com/user-attachments/assets/21c9cf9e-5858-4403-9106-57ed8ccf3639">





### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaStoeva ElenaStoeva

Labels
enhancement New value added to drive a business result Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
8.17
Development

Successfully merging a pull request may close this issue.

[Index Management] Add index mode field in index template form ElenaStoeva/kibana
4 participants
@alisonelizabeth @elasticmachine @ElenaStoeva @bitzandeb