Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canvas error if esdocs sort property without sort direction #198591

Closed
dolivanu opened this issue Oct 31, 2024 · 2 comments
Closed

Canvas error if esdocs sort property without sort direction #198591

dolivanu opened this issue Oct 31, 2024 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@dolivanu
Copy link

dolivanu commented Oct 31, 2024

Kibana version: 8.15.3

Elasticsearch version: 8.15.3

Server OS version: Cloud & on-prem Windows Server 2022

Browser version: MS Edge 130.0.2849.56

Browser OS version: Windows 10 22H2 10.0.19045 Build 19045

Original install method (e.g. download page, yum, from source, etc.): Cloud & ZIP from download page

Describe the bug:

Steps to reproduce:

  1. Canvas, select Create workpad
  2. Add element : Data table
  3. Click on the table
  4. Click on Expression editor
  5. Change the default expression to:
esdocs index="metrics-*" count=10 sort="agent.type"
| table
| render
  1. Click on Run
  2. Gives error Unable to load page
  3. Click on Refresh loads the page again, but if click on table, raises the same error

Expected behavior:
The esdocs sort property with the syntax error should raise a controlled error when pressing Run, allowing the user to fix it on the Expression editor, as other syntax errors.

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

TypeError: t.renderError is not a function
    at https://my-deployment-XXX.kb.eu-central-1.aws.cloud.es.io/XXXaa/bundles/plugin/canvas/1.0.0/canvas.chunk.12.js:16:13571
    at u (https://my-deployment-XXX.kb.eu-central-1.aws.cloud.es.io/XXXaa/bundles/plugin/canvas/1.0.0/canvas.chunk.7.js:3:17944)
    at la (https://my-deployment-XXX.kb.eu-central-1.aws.cloud.es.io/XXXaa/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:429:59212)
    at ec (https://my-deployment-XXX.kb.eu-central-1.aws.cloud.es.io/XXXaa/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:429:114853)

Any additional context:
The problem is when editing the expression directly on the bottom panel and include a syntax error in esdocs property sort with only the property name, not including sort direction, sort="agent.type" versus sort="agent.type, desc".

You can not edit the table anymore. To solve the issue, you can download the workpad JSON file, remove the sort property entirely and load the workpad again.

@dolivanu dolivanu added the bug Fixes for quality problems that affect the customer experience label Oct 31, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 31, 2024
@dmlemeshko dmlemeshko added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Nov 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 2, 2024
@kibanamachine kibanamachine added loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Nov 2, 2024
@ThomThomson
Copy link
Contributor

Closing this for now as we are not prioritizing fixing Canvas bugs unless they are major regressions.

@ThomThomson ThomThomson closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

5 participants