Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Unauthorized Services Visible in APM Service Inventory Due to Alerts #198497

Open
cauemarcondes opened this issue Oct 31, 2024 · 2 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience sdh-linked Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@cauemarcondes
Copy link
Contributor

cauemarcondes commented Oct 31, 2024

Services that users lack access permissions for are currently visible in the APM Service inventory when triggered by alerts. This unintended behaviour exposes unauthorized services to users, compromising access restrictions.

The expected behaviour is for APM to exclude services from alerts if the user does not have access, similar to how access is managed in ML. This issue aims to adjust alert handling in APM to ensure that only authorized services are visible in the Service inventory.

Image

The last two services are only listed because they have alerts, as seen there are no APM metrics available.

Solution:

We must apply the same filtering as done on services coming from ML https://github.com/elastic/kibana/blob/main/x-pack/plugins/observability_solution/apm/server/routes/services/get_services/merge_service_stats.ts#L52-L54

@cauemarcondes cauemarcondes added bug Fixes for quality problems that affect the customer experience sdh-linked Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 31, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kpatticha
Copy link
Contributor

it's worth mentioning

  • We show only the service name, we don't show any other information that the user is not authorised
  • from my understanding, the fix should be really easy and straightforward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience sdh-linked Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

No branches or pull requests

4 participants