Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Cases] Use one delete confirmation modal in the codebase #198488

Open
cnasikas opened this issue Oct 31, 2024 · 2 comments
Open

[ResponseOps][Cases] Use one delete confirmation modal in the codebase #198488

cnasikas opened this issue Oct 31, 2024 · 2 comments
Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture

Comments

@cnasikas
Copy link
Member

cnasikas commented Oct 31, 2024 •
edited
Loading

I noticed that we have a lot of delete confirmation modal components which are quite similar. We should have one global component that can be used across the codebase. At the moment of writing this issue, there are the following:

  • DeleteConfirmationModal in x-pack/plugins/cases/public/components/configure_cases/delete_confirmation_modal.tsx
  • ConfirmDeleteCaseModal in x-pack/plugins/cases/public/components/confirm_delete_case/index.tsx
  • CancelCreationConfirmationModal in x-pack/plugins/cases/public/components/create/cancel_creation_confirmation_modal.tsx
  • DeleteConfirmationModal in x-pack/plugins/cases/public/components/custom_fields/delete_confirmation_modal.tsx
  • DeleteAttachmentConfirmationModal in x-pack/plugins/cases/public/components/user_actions/delete_attachment_confirmation_modal.tsx
@cnasikas cnasikas added Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture labels Oct 31, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cnasikas @elasticmachine