[CLOUD-UI] Cloud onboarding token #198444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
Team:Cloud
release_note:skip
x-pack/plugins/cloud/server/saved_objects/get_cloud_onboarding_data.ts
Outdated
Show resolved
Hide resolved
…to cloud-onboarding-token
afharo
reviewed
Nov 5, 2024
… src/core/server/integration_tests/ci_checks'
…to cloud-onboarding-token
Ikuni17
approved these changes
Nov 5, 2024
afharo
added
the
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
| */ | ||
|
|
||
| import { httpServerMock, httpServiceMock } from '@kbn/core/server/mocks'; | ||
| import { setDefaultSpaceSolutionType } from './set_cloud_data_route'; |
There was a problem hiding this comment.
Should this be setPostCloudSolutionDataRoute?
| .send({ | ||
| onboardingData: { | ||
| solutionType: 'search', | ||
| token: 'connectors', |
There was a problem hiding this comment.
how confident are we that token won't expose sensitive data?
There was a problem hiding this comment.
we are super confident ;)
|
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 19, 2024
## Summary The solution must be aware of the onboarding token from the cloud onboarding flow. With this information, it can redirect our users to the appropriate onboarding flow in Kibana based on their token. We need to create an API in kibana for cloud to save some basic data. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Christiane (Tina) Heiligers <[email protected]> Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 158a828)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 20, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[CLOUD-UI] Cloud onboarding token (#198444)](#198444) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Xavier Mouligneau","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-19T23:42:09Z","message":"[CLOUD-UI] Cloud onboarding token (#198444)\n\n## Summary\r\n\r\nThe solution must be aware of the onboarding token from the cloud\r\nonboarding flow. With this information, it can redirect our users to the\r\nappropriate onboarding flow in Kibana based on their token. We need to\r\ncreate an API in kibana for cloud to save some basic data.\r\n\r\n### Checklist\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Christiane (Tina) Heiligers <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"158a828a8e4cf78390fa8711666609c8e16a71ca","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","Team:Cloud","release_note:skip","v9.0.0","backport:version","v8.17.0"],"title":"[CLOUD-UI] Cloud onboarding token","number":198444,"url":"https://github.com/elastic/kibana/pull/198444","mergeCommit":{"message":"[CLOUD-UI] Cloud onboarding token (#198444)\n\n## Summary\r\n\r\nThe solution must be aware of the onboarding token from the cloud\r\nonboarding flow. With this information, it can redirect our users to the\r\nappropriate onboarding flow in Kibana based on their token. We need to\r\ncreate an API in kibana for cloud to save some basic data.\r\n\r\n### Checklist\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Christiane (Tina) Heiligers <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"158a828a8e4cf78390fa8711666609c8e16a71ca"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198444","number":198444,"mergeCommit":{"message":"[CLOUD-UI] Cloud onboarding token (#198444)\n\n## Summary\r\n\r\nThe solution must be aware of the onboarding token from the cloud\r\nonboarding flow. With this information, it can redirect our users to the\r\nappropriate onboarding flow in Kibana based on their token. We need to\r\ncreate an API in kibana for cloud to save some basic data.\r\n\r\n### Checklist\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Christiane (Tina) Heiligers <[email protected]>\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"158a828a8e4cf78390fa8711666609c8e16a71ca"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Xavier Mouligneau <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
## Summary The solution must be aware of the onboarding token from the cloud onboarding flow. With this information, it can redirect our users to the appropriate onboarding flow in Kibana based on their token. We need to create an API in kibana for cloud to save some basic data. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Christiane (Tina) Heiligers <[email protected]> Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary The solution must be aware of the onboarding token from the cloud onboarding flow. With this information, it can redirect our users to the appropriate onboarding flow in Kibana based on their token. We need to create an API in kibana for cloud to save some basic data. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Christiane (Tina) Heiligers <[email protected]> Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The solution must be aware of the onboarding token from the cloud onboarding flow. With this information, it can redirect our users to the appropriate onboarding flow in Kibana based on their token. We need to create an API in kibana for cloud to save some basic data.
Checklist