-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Adapt special character escape according to kuery grammer #198288
Conversation
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
x-pack/plugins/timelines/public/components/utils/keury/index.test.ts
Outdated
Show resolved
Hide resolved
3c7c527
to
c0b7a1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@logeekal is there anything we can do to assist with this PR? Do we "just" need a clean CI run? |
/ci |
@elasticmachine merge upstream |
There are no new commits on the base branch. |
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
|
This PR didn't make it on time to the latest v7.17.26 BC. Updating the labels. |
Thanks @mistic |
Summary
Fixes https://github.com/elastic/kibana-team/issues/1107
As mentioned in https://github.com/elastic/kibana/security/code-scanning/349, this PR resolves the escaping issue.
Additionally, it also adds more candiadates for escaping as mentioned in
kuery
grammar as shown below .kibana/packages/kbn-es-query/grammar/grammar.peggy
Lines 295 to 298 in d6b4fe9
Solution
This PR replicates #128289 in
7.17
whereescape_kquery
was moved fromdata
plugin toes-query
package. This should have been backported to7.17
but was not.