fix: kibana dev server not restarting for external plugin #171260 #198246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
Completed |
|
/ci |
Ikuni17
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
The kibana dev server was not restarting during external plugin development for server side code. fixes elastic#171260
`plugins/myPlugin/kibana.json` should restart the dev server when changed. e.g. adding a required plugin
mickalpine
force-pushed
the
fix/Kibana-server-is-not-restarting-when-during-development
branch
from
b566637 to
4ccd0ec
Compare
|
/ci |
|
run docs-build |
|
/ci |
mistic
approved these changes
Nov 19, 2024
💚 Build Succeeded
Metrics [docs]
History
|
|
run docs-build |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 20, 2024
(elastic#198246) ## Summary Fixes elastic#171260 the Kibana dev server not restarting during external plugin development for server side code. ### Checklist ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release note Fixes elastic#171260 the Kibana dev server not restarting during external plugin development for server side code. --------- Co-authored-by: Brad White <[email protected]> (cherry picked from commit 83b282a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 20, 2024
… (#198246) (#201040) # Backport This will backport the following commits from `main` to `8.x`: - [fix: kibana dev server not restarting for external plugin #171260 (#198246)](#198246) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jordan McAlpine","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T20:24:58Z","message":"fix: kibana dev server not restarting for external plugin #171260 (#198246)\n\n## Summary\r\n\r\nFixes #171260 the Kibana dev server not restarting during external\r\nplugin development for server side code.\r\n\r\n### Checklist\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n- [ ] This will appear in the **Release Notes** and follow the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\nFixes #171260 the Kibana dev server not restarting during external\r\nplugin development for server side code.\r\n\r\n---------\r\n\r\nCo-authored-by: Brad White <[email protected]>","sha":"83b282a63a3748a07a0d9e69f2cafa44b9439af7","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","💝community","v9.0.0","backport:prev-minor"],"title":"fix: kibana dev server not restarting for external plugin #171260","number":198246,"url":"https://github.com/elastic/kibana/pull/198246","mergeCommit":{"message":"fix: kibana dev server not restarting for external plugin #171260 (#198246)\n\n## Summary\r\n\r\nFixes #171260 the Kibana dev server not restarting during external\r\nplugin development for server side code.\r\n\r\n### Checklist\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n- [ ] This will appear in the **Release Notes** and follow the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\nFixes #171260 the Kibana dev server not restarting during external\r\nplugin development for server side code.\r\n\r\n---------\r\n\r\nCo-authored-by: Brad White <[email protected]>","sha":"83b282a63a3748a07a0d9e69f2cafa44b9439af7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198246","number":198246,"mergeCommit":{"message":"fix: kibana dev server not restarting for external plugin #171260 (#198246)\n\n## Summary\r\n\r\nFixes #171260 the Kibana dev server not restarting during external\r\nplugin development for server side code.\r\n\r\n### Checklist\r\n\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)\r\n- [ ] This will appear in the **Release Notes** and follow the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n## Release note\r\nFixes #171260 the Kibana dev server not restarting during external\r\nplugin development for server side code.\r\n\r\n---------\r\n\r\nCo-authored-by: Brad White <[email protected]>","sha":"83b282a63a3748a07a0d9e69f2cafa44b9439af7"}}]}] BACKPORT--> Co-authored-by: Jordan McAlpine <[email protected]>
TattdCodeMonkey
pushed a commit
to TattdCodeMonkey/kibana
that referenced
this pull request
Nov 21, 2024
(elastic#198246) ## Summary Fixes elastic#171260 the Kibana dev server not restarting during external plugin development for server side code. ### Checklist ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release note Fixes elastic#171260 the Kibana dev server not restarting during external plugin development for server side code. --------- Co-authored-by: Brad White <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
(elastic#198246) ## Summary Fixes elastic#171260 the Kibana dev server not restarting during external plugin development for server side code. ### Checklist ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release note Fixes elastic#171260 the Kibana dev server not restarting during external plugin development for server side code. --------- Co-authored-by: Brad White <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
(elastic#198246) ## Summary Fixes elastic#171260 the Kibana dev server not restarting during external plugin development for server side code. ### Checklist ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ## Release note Fixes elastic#171260 the Kibana dev server not restarting during external plugin development for server side code. --------- Co-authored-by: Brad White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #171260 the Kibana dev server not restarting during external plugin development for server side code.
Checklist
For maintainers
Release note
Fixes #171260 the Kibana dev server not restarting during external plugin development for server side code.