Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search:Connectors:SyncRules page]Issues with Draft Rules flyout table #198135

Open
L1nBra opened this issue Oct 29, 2024 · 2 comments
Open

[Search:Connectors:SyncRules page]Issues with Draft Rules flyout table #198135

L1nBra opened this issue Oct 29, 2024 · 2 comments
Labels
defect-level-2 Serious UX disruption with workaround impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Accessibility Team:Search WCAG A WCAG AA

Comments

@L1nBra
Copy link

L1nBra commented Oct 29, 2024

Description
Table should be correctly defined in the code, that for users, using assistive technology it would be clearly announced as a table. That users would know what this table consists of and what values are present for which columns.
Instructions about the table, how to perform drag and drop actions, should be enough for the user to hear them only one time when navigating to the row, not to hear with each element, otherwise user can get overwhelmed.
Focus should be visible on corresponding element on which user is at the moment and elements itself shouldn't be duplicated.

Preconditions
Stateful Connectors -> Sync Rules page is opened.
Connectors are added.
Few Sync rules are added.
Use Screen Reader (NVDA).

Steps to reproduce

1.Navigate to Draft new sync rules while using only keyboard by pressing Tab key.
2.Press Enter.
3.Navigate to the table.
4.Navigate through the table pressing Tab key.
5.Observe Screen Reader announcement.
6.Navigate to Add sync rule button.
7.Press Enter.
8.Navigate through newly appeared row by pressing Tab key.
9.Observe Screen Reader announcement.

NVDA Speech Viewer + UI elements
navigating through the table
Image

Image

When adding new sync rule
Image

Html snippet
Image

Actual Result

  1. No announcement about the table, table's columns. Only the values in the row are announced. When pressing T key with NVDA turned on - it doesn't find table at all.
  2. Instructions about drag and drop are announced with each element (with the row, with Edit button, with Delete button).
  3. Duplicated button announcement for Edit, Delete buttons.
  4. No focus visible after pressing Tab key when user is on Add sync rule button.
  5. When adding new sync rule - for the new row fields are announced without names/labels (or without any explanation), only as "combo box Include collapsed", "edit blank".

Expected Result

  1. Table is found when using screen reader and correctly announced with how many rows are present, what columns are present in it.
  2. It would be better if instructions for drag and drop are announced one time when user navigates to the row.
  3. Button is announced one time ("Edit button").
  4. After Add sync rule button, focus should be on the row in the table (because if user press Spacebar he/she can drag and drop the row).
  5. It should be clearly announced for the user on which field he/she is at the moment (the value and for which column).

Meta Issue

Kibana Version: 8.17.0-SNAPSHOT

OS: Windows 11 Pro

Browser: Chrome Version 130.0.6723.70 (Official Build) (64-bit)

Screen reader: NVDA

WCAG or Vendor Guidance (optional)

Related to: https://github.com/elastic/search-team/issues/8256

@L1nBra L1nBra added defect-level-2 Serious UX disruption with workaround impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Accessibility Team:Search WCAG A WCAG AA labels Oct 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@L1nBra L1nBra changed the title [Stateful:Connectors:SyncRules page]Issues with Draft Rules flyout table [Search:Connectors:SyncRules page]Issues with Draft Rules flyout table Nov 7, 2024
@erikcurrin-elastic
Copy link

This requires a rewrite of the code to produce a table or research on how to make the divs look like a table to a screen reader.

@erikcurrin-elastic erikcurrin-elastic added loe:medium Medium Level of Effort and removed a11y:med-effort labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect-level-2 Serious UX disruption with workaround impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Accessibility Team:Search WCAG A WCAG AA
Projects
None yet
Development

No branches or pull requests

5 participants