improve loading UI in Discover mobile #197939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
davismcphee
added
the
Team:DataDiscovery
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
Thx a lot for your contribution @youhonglian , could you take care of the failing Jest tests, the FTR (functional) test failure appears to be unrelated. Many thx! |
|
/ci |
1 similar comment
|
/ci |
davismcphee
added
release_note:skip
|
/ci |
|
@elasticmachine run docs-build |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
davismcphee
approved these changes
Oct 30, 2024
|
@elasticmachine run docs-build |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 30, 2024
## Summary Closes elastic#151503 In this PR, use the EuiEmptyPrompt component to update the loading UI --------- Co-authored-by: Davis McPhee <[email protected]> (cherry picked from commit 7d0f15b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [improve loading UI in Discover mobile (#197939)](#197939) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"youhonglian","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T23:41:06Z","message":"improve loading UI in Discover mobile (#197939)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/151503\r\n\r\nIn this PR, use the EuiEmptyPrompt component to update the loading UI\r\n\r\n---------\r\n\r\nCo-authored-by: Davis McPhee <[email protected]>","sha":"7d0f15b160fd2c7bc1d80e62f3499827970fccc1","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","💝community","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"improve loading UI in Discover mobile","number":197939,"url":"https://github.com/elastic/kibana/pull/197939","mergeCommit":{"message":"improve loading UI in Discover mobile (#197939)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/151503\r\n\r\nIn this PR, use the EuiEmptyPrompt component to update the loading UI\r\n\r\n---------\r\n\r\nCo-authored-by: Davis McPhee <[email protected]>","sha":"7d0f15b160fd2c7bc1d80e62f3499827970fccc1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197939","number":197939,"mergeCommit":{"message":"improve loading UI in Discover mobile (#197939)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/151503\r\n\r\nIn this PR, use the EuiEmptyPrompt component to update the loading UI\r\n\r\n---------\r\n\r\nCo-authored-by: Davis McPhee <[email protected]>","sha":"7d0f15b160fd2c7bc1d80e62f3499827970fccc1"}}]}] BACKPORT--> Co-authored-by: youhonglian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #151503
In this PR, use the EuiEmptyPrompt component to update the loading UI