Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Set disk size for artifact builds #197663

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Oct 24, 2024

Defines disk size for artifact builds. This will be a no-op - the boot disk size is >= the definitions in this PR.

A test run with the smaller boot disk can be seen in https://buildkite.com/elastic/kibana-pull-request/builds/248242. I plan on making further adjustments after the boot disk has been promoted.

@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Oct 24, 2024
@jbudz
Copy link
Member Author

jbudz commented Oct 24, 2024

buildkite test this

3 similar comments
@jbudz
Copy link
Member Author

jbudz commented Nov 4, 2024

buildkite test this

@jbudz
Copy link
Member Author

jbudz commented Nov 4, 2024

buildkite test this

@jbudz
Copy link
Member Author

jbudz commented Nov 5, 2024

buildkite test this

@jbudz jbudz marked this pull request as ready for review November 5, 2024 21:19
@jbudz jbudz requested review from a team as code owners November 5, 2024 21:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Ikuni17
Ikuni17 previously approved these changes Nov 6, 2024
drewdaemon
drewdaemon previously approved these changes Nov 6, 2024
We'll be decreasing the boot disk size in a separate PR.  These two
steps need more space beyond the default.
@jbudz jbudz dismissed stale reviews from drewdaemon and Ikuni17 November 25, 2024 22:34

out of date

@jbudz jbudz requested a review from a team November 25, 2024 22:34
@jbudz
Copy link
Member Author

jbudz commented Nov 25, 2024

Apologies for the force push. I reverted most of the changes in this PR to avoid a major amount of backport merge conflicts.

We'll be using the default disk size (100gb) instead of the boot disk size for all steps unless otherwise defined. The full artifacts build is a little short on disk space, but everything else has enough space - #189730

@jbudz jbudz changed the title [ci] Set disk size [ci] Set disk size for artifact builds Nov 25, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@jbudz jbudz merged commit 316efc7 into elastic:main Nov 26, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 7.17, 8.15, 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12040842932

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 26, 2024
Defines disk size for artifact builds. This will be a no-op - the boot
disk size is >= the definitions in this PR.

A test run with the smaller boot disk can be seen in
https://buildkite.com/elastic/kibana-pull-request/builds/248242. I plan
on making further adjustments after the boot disk has been promoted.

(cherry picked from commit 316efc7)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 26, 2024
Defines disk size for artifact builds. This will be a no-op - the boot
disk size is >= the definitions in this PR.

A test run with the smaller boot disk can be seen in
https://buildkite.com/elastic/kibana-pull-request/builds/248242. I plan
on making further adjustments after the boot disk has been promoted.

(cherry picked from commit 316efc7)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 26, 2024
Defines disk size for artifact builds. This will be a no-op - the boot
disk size is >= the definitions in this PR.

A test run with the smaller boot disk can be seen in
https://buildkite.com/elastic/kibana-pull-request/builds/248242. I plan
on making further adjustments after the boot disk has been promoted.

(cherry picked from commit 316efc7)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 26, 2024
Defines disk size for artifact builds. This will be a no-op - the boot
disk size is >= the definitions in this PR.

A test run with the smaller boot disk can be seen in
https://buildkite.com/elastic/kibana-pull-request/builds/248242. I plan
on making further adjustments after the boot disk has been promoted.

(cherry picked from commit 316efc7)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- chore(NA): bump node into v20 (#173461)
- Upgrade to Node.js 20 (#162696)
- [artifacts] Add CI retries (#130194)
- [artifacts] Publish (#129499)
- [artifacts] Merge docker context verification (#129399)
- [artifacts] Merge package testing with release artifacts (#129378)
8.15
8.16
8.17
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 197663

Questions ?

Please refer to the Backport tool documentation

jbudz added a commit to jbudz/kibana that referenced this pull request Nov 26, 2024
Defines disk size for artifact builds. This will be a no-op - the boot
disk size is >= the definitions in this PR.

A test run with the smaller boot disk can be seen in
https://buildkite.com/elastic/kibana-pull-request/builds/248242. I plan
on making further adjustments after the boot disk has been promoted.
kibanamachine added a commit that referenced this pull request Nov 27, 2024
# Backport

This will backport the following commits from `main` to `8.15`:
- [[ci] Set disk size for artifact builds
(#197663)](#197663)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T23:35:57Z","message":"[ci]
Set disk size for artifact builds (#197663)\n\nDefines disk size for
artifact builds. This will be a no-op - the boot\r\ndisk size is >= the
definitions in this PR.\r\n\r\nA test run with the smaller boot disk can
be seen
in\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/248242. I
plan\r\non making further adjustments after the boot disk has been
promoted.","sha":"316efc71d67ed565b7b6aad2947cb380ac39db1b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:all-open"],"title":"[ci]
Set disk size for artifact
builds","number":197663,"url":"https://github.com/elastic/kibana/pull/197663","mergeCommit":{"message":"[ci]
Set disk size for artifact builds (#197663)\n\nDefines disk size for
artifact builds. This will be a no-op - the boot\r\ndisk size is >= the
definitions in this PR.\r\n\r\nA test run with the smaller boot disk can
be seen
in\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/248242. I
plan\r\non making further adjustments after the boot disk has been
promoted.","sha":"316efc71d67ed565b7b6aad2947cb380ac39db1b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197663","number":197663,"mergeCommit":{"message":"[ci]
Set disk size for artifact builds (#197663)\n\nDefines disk size for
artifact builds. This will be a no-op - the boot\r\ndisk size is >= the
definitions in this PR.\r\n\r\nA test run with the smaller boot disk can
be seen
in\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/248242. I
plan\r\non making further adjustments after the boot disk has been
promoted.","sha":"316efc71d67ed565b7b6aad2947cb380ac39db1b"}}]}]
BACKPORT-->

Co-authored-by: Jon <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 27, 2024
# Backport

This will backport the following commits from `main` to `8.16`:
- [[ci] Set disk size for artifact builds
(#197663)](#197663)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T23:35:57Z","message":"[ci]
Set disk size for artifact builds (#197663)\n\nDefines disk size for
artifact builds. This will be a no-op - the boot\r\ndisk size is >= the
definitions in this PR.\r\n\r\nA test run with the smaller boot disk can
be seen
in\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/248242. I
plan\r\non making further adjustments after the boot disk has been
promoted.","sha":"316efc71d67ed565b7b6aad2947cb380ac39db1b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:all-open"],"title":"[ci]
Set disk size for artifact
builds","number":197663,"url":"https://github.com/elastic/kibana/pull/197663","mergeCommit":{"message":"[ci]
Set disk size for artifact builds (#197663)\n\nDefines disk size for
artifact builds. This will be a no-op - the boot\r\ndisk size is >= the
definitions in this PR.\r\n\r\nA test run with the smaller boot disk can
be seen
in\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/248242. I
plan\r\non making further adjustments after the boot disk has been
promoted.","sha":"316efc71d67ed565b7b6aad2947cb380ac39db1b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197663","number":197663,"mergeCommit":{"message":"[ci]
Set disk size for artifact builds (#197663)\n\nDefines disk size for
artifact builds. This will be a no-op - the boot\r\ndisk size is >= the
definitions in this PR.\r\n\r\nA test run with the smaller boot disk can
be seen
in\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/248242. I
plan\r\non making further adjustments after the boot disk has been
promoted.","sha":"316efc71d67ed565b7b6aad2947cb380ac39db1b"}}]}]
BACKPORT-->

Co-authored-by: Jon <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 27, 2024
# Backport

This will backport the following commits from `main` to `8.17`:
- [[ci] Set disk size for artifact builds
(#197663)](#197663)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T23:35:57Z","message":"[ci]
Set disk size for artifact builds (#197663)\n\nDefines disk size for
artifact builds. This will be a no-op - the boot\r\ndisk size is >= the
definitions in this PR.\r\n\r\nA test run with the smaller boot disk can
be seen
in\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/248242. I
plan\r\non making further adjustments after the boot disk has been
promoted.","sha":"316efc71d67ed565b7b6aad2947cb380ac39db1b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:all-open"],"title":"[ci]
Set disk size for artifact
builds","number":197663,"url":"https://github.com/elastic/kibana/pull/197663","mergeCommit":{"message":"[ci]
Set disk size for artifact builds (#197663)\n\nDefines disk size for
artifact builds. This will be a no-op - the boot\r\ndisk size is >= the
definitions in this PR.\r\n\r\nA test run with the smaller boot disk can
be seen
in\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/248242. I
plan\r\non making further adjustments after the boot disk has been
promoted.","sha":"316efc71d67ed565b7b6aad2947cb380ac39db1b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197663","number":197663,"mergeCommit":{"message":"[ci]
Set disk size for artifact builds (#197663)\n\nDefines disk size for
artifact builds. This will be a no-op - the boot\r\ndisk size is >= the
definitions in this PR.\r\n\r\nA test run with the smaller boot disk can
be seen
in\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/248242. I
plan\r\non making further adjustments after the boot disk has been
promoted.","sha":"316efc71d67ed565b7b6aad2947cb380ac39db1b"}}]}]
BACKPORT-->

Co-authored-by: Jon <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 27, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ci] Set disk size for artifact builds
(#197663)](#197663)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T23:35:57Z","message":"[ci]
Set disk size for artifact builds (#197663)\n\nDefines disk size for
artifact builds. This will be a no-op - the boot\r\ndisk size is >= the
definitions in this PR.\r\n\r\nA test run with the smaller boot disk can
be seen
in\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/248242. I
plan\r\non making further adjustments after the boot disk has been
promoted.","sha":"316efc71d67ed565b7b6aad2947cb380ac39db1b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:all-open"],"title":"[ci]
Set disk size for artifact
builds","number":197663,"url":"https://github.com/elastic/kibana/pull/197663","mergeCommit":{"message":"[ci]
Set disk size for artifact builds (#197663)\n\nDefines disk size for
artifact builds. This will be a no-op - the boot\r\ndisk size is >= the
definitions in this PR.\r\n\r\nA test run with the smaller boot disk can
be seen
in\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/248242. I
plan\r\non making further adjustments after the boot disk has been
promoted.","sha":"316efc71d67ed565b7b6aad2947cb380ac39db1b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197663","number":197663,"mergeCommit":{"message":"[ci]
Set disk size for artifact builds (#197663)\n\nDefines disk size for
artifact builds. This will be a no-op - the boot\r\ndisk size is >= the
definitions in this PR.\r\n\r\nA test run with the smaller boot disk can
be seen
in\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/248242. I
plan\r\non making further adjustments after the boot disk has been
promoted.","sha":"316efc71d67ed565b7b6aad2947cb380ac39db1b"}}]}]
BACKPORT-->

Co-authored-by: Jon <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
Defines disk size for artifact builds. This will be a no-op - the boot
disk size is >= the definitions in this PR.

A test run with the smaller boot disk can be seen in
https://buildkite.com/elastic/kibana-pull-request/builds/248242. I plan
on making further adjustments after the boot disk has been promoted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.15.5 v8.16.2 v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants