[Lens] Prevent identical include and exclude values #197628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VriaA
force-pushed
the
fix/lens-include-and-exclude-values
branch
from
e8bb295 to
fdda52f
Compare
mbondyra
added
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
mbondyra
reviewed
Nov 4, 2024
.../lens/public/datasources/form_based/operations/definitions/terms/include_exclude_options.tsx
Outdated
Show resolved
Hide resolved
mbondyra
reviewed
Nov 5, 2024
.../lens/public/datasources/form_based/operations/definitions/terms/include_exclude_options.tsx
Show resolved
Hide resolved
mbondyra
approved these changes
Nov 8, 2024
mbondyra
changed the title
|
buildkite test this |
|
run docs-build |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Nov 12, 2024
## Summary Fixes elastic#194639 - This PR adds filtering logic to: - `onChangeIncludeExcludeOptions` - `onCreateOption` - `onIncludeRegexChangeToDebounce` - `onExcludeRegexChangeToDebounce` These changes prevent the include and exclude fields from having the same values simultaneously. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios https://github.com/user-attachments/assets/8f848c2a-0bea-46c6-b335-b04d62c12aef --------- Co-authored-by: Marta Bondyra <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
@mbondyra is there a reason not to backport this to the |
nickofthyme
added
the
backport:current-major
mbondyra
added
backport:prev-minor
|
Starting backport for target branches: 8.x |
|
Sounds good @nickofthyme 👌🏼 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 14, 2024
## Summary Fixes elastic#194639 - This PR adds filtering logic to: - `onChangeIncludeExcludeOptions` - `onCreateOption` - `onIncludeRegexChangeToDebounce` - `onExcludeRegexChangeToDebounce` These changes prevent the include and exclude fields from having the same values simultaneously. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios https://github.com/user-attachments/assets/8f848c2a-0bea-46c6-b335-b04d62c12aef --------- Co-authored-by: Marta Bondyra <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 750e578)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 14, 2024
…200133) # Backport This will backport the following commits from `main` to `8.x`: - [[lens] Prevent identical include and exclude values (#197628)](#197628) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Oyelola Victoria","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-11T16:48:23Z","message":"[lens] Prevent identical include and exclude values (#197628)\n\n## Summary\r\n\r\nFixes #194639\r\n\r\n- This PR adds filtering logic to:\r\n - `onChangeIncludeExcludeOptions`\r\n - `onCreateOption`\r\n - `onIncludeRegexChangeToDebounce` \r\n - `onExcludeRegexChangeToDebounce`\r\n\r\nThese changes prevent the include and exclude fields from having the\r\nsame values simultaneously.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8f848c2a-0bea-46c6-b335-b04d62c12aef\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"750e578f2867d1ad6bf2f1f7506a1d75f2d77d05","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","backport missing","💝community","v9.0.0","backport:current-major"],"title":"[Lens] Prevent identical include and exclude values","number":197628,"url":"https://github.com/elastic/kibana/pull/197628","mergeCommit":{"message":"[lens] Prevent identical include and exclude values (#197628)\n\n## Summary\r\n\r\nFixes #194639\r\n\r\n- This PR adds filtering logic to:\r\n - `onChangeIncludeExcludeOptions`\r\n - `onCreateOption`\r\n - `onIncludeRegexChangeToDebounce` \r\n - `onExcludeRegexChangeToDebounce`\r\n\r\nThese changes prevent the include and exclude fields from having the\r\nsame values simultaneously.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8f848c2a-0bea-46c6-b335-b04d62c12aef\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"750e578f2867d1ad6bf2f1f7506a1d75f2d77d05"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197628","number":197628,"mergeCommit":{"message":"[lens] Prevent identical include and exclude values (#197628)\n\n## Summary\r\n\r\nFixes #194639\r\n\r\n- This PR adds filtering logic to:\r\n - `onChangeIncludeExcludeOptions`\r\n - `onCreateOption`\r\n - `onIncludeRegexChangeToDebounce` \r\n - `onExcludeRegexChangeToDebounce`\r\n\r\nThese changes prevent the include and exclude fields from having the\r\nsame values simultaneously.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8f848c2a-0bea-46c6-b335-b04d62c12aef\r\n\r\n---------\r\n\r\nCo-authored-by: Marta Bondyra <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"750e578f2867d1ad6bf2f1f7506a1d75f2d77d05"}}]}] BACKPORT--> Co-authored-by: Oyelola Victoria <[email protected]>
kibanamachine
added
v8.17.0
and removed
backport missing
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
## Summary Fixes elastic#194639 - This PR adds filtering logic to: - `onChangeIncludeExcludeOptions` - `onCreateOption` - `onIncludeRegexChangeToDebounce` - `onExcludeRegexChangeToDebounce` These changes prevent the include and exclude fields from having the same values simultaneously. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios https://github.com/user-attachments/assets/8f848c2a-0bea-46c6-b335-b04d62c12aef --------- Co-authored-by: Marta Bondyra <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #194639
onChangeIncludeExcludeOptionsonCreateOptiononIncludeRegexChangeToDebounceonExcludeRegexChangeToDebounceThese changes prevent the include and exclude fields from having the same values simultaneously.
Checklist
include_exclude.1.mp4