Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Management] Number fields accept invalid input #197506

Open
ElenaStoeva opened this issue Oct 23, 2024 · 5 comments
Open

[Management] Number fields accept invalid input #197506

ElenaStoeva opened this issue Oct 23, 2024 · 5 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@ElenaStoeva
Copy link
Contributor

ElenaStoeva commented Oct 23, 2024

While testing #196527, I noticed that different form fields in Kibana Management plugins accept invalid input in number fields.
Examples I noticed:

  • Ingest pipelines creation flow - add processor form
  • ILM creation flow
Screen.Recording.2024-10-23.at.17.59.31.mov
Screen.Recording.2024-10-23.at.18.02.27.mov

I think the e, -, and , characters are allowed by the Eui number field itself and it contains some validation for valid numbers. We should probably add validations from our side for valid numbers as well and not allow submitting the form if the number is invalid.

@ElenaStoeva ElenaStoeva added bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Oct 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@alisonelizabeth alisonelizabeth added the good first issue low hanging fruit label Nov 8, 2024
@Prakhar29Sharma
Copy link

I’d like to contribute to fixing this by adding validation on our side to ensure only valid numbers are allowed, preventing the form from being submitted with invalid input.

As I'm new to open source development, I'd really appreciate any guidance or suggestions on how to get started with this issue. Would it be possible to have this issue assigned to me?

Thank you!

@ElenaStoeva
Copy link
Contributor Author

ElenaStoeva commented Jan 7, 2025

Thanks for expressing interest in fixing this @Prakhar29Sharma! I don't think we have plans on working on this in the near future so I'll go ahead and assign it to you (@alisonelizabeth please let us know if you have any objections).

Regarding guidelines for contributing to Kibana, I would suggest starting with these docs.

@SoniaSanzV
Copy link
Contributor

Regarding guidelines for contributing to Kibana, I would suggest starting with these docs.

@ElenaStoeva, I think this is the internal documentation. If I'm not mistaken, for external contributors the right documentation is the one in the elastic page: https://www.elastic.co/guide/en/kibana/current/contributing.html

@ElenaStoeva
Copy link
Contributor Author

@SoniaSanzV you're right, appologies for the confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

5 participants