Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Chrome UI Functional Tests.test/functional/apps/discover/group3/_lens_vis·ts - discover/group3 discover lens vis should be able to load a saved search with custom vis, edit vis and revert changes #197342

Closed
kibanamachine opened this issue Oct 22, 2024 · 15 comments · Fixed by #197583
Closed

Failing test: Chrome UI Functional Tests.test/functional/apps/discover/group3/_lens_vis·ts - discover/group3 discover lens vis should be able to load a saved search with custom vis, edit vis and revert changes #197342

kibanamachine opened this issue Oct 22, 2024 · 15 comments · Fixed by #197583
Assignees
@mbondyra
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 22, 2024 •
edited
Loading

A test failed on a tracked branch

Error: timed out waiting for suggestion option
    at onFailure (retry_for_truthy.ts:40:13)
    at retryForSuccess (retry_for_success.ts:85:7)
    at retryForTruthy (retry_for_truthy.ts:28:3)
    at RetryService.waitFor (retry.ts:88:5)
    at DiscoverPageObject.chooseLensSuggestion (discover_page.ts:257:5)
    at Context.<anonymous> (_lens_vis.ts:618:7)
    at Object.apply (wrap_function.js:74:16)

First failure: kibana-on-merge - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Oct 22, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 22, 2024
@kibanamachine kibanamachine added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Oct 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 22, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@jbudz
Copy link
Member

jbudz commented Oct 22, 2024

/skip

@kibanamachine
Copy link
Contributor Author

Skipped

main: f7f122c

kibanamachine added a commit that referenced this issue Oct 22, 2024
@kibanamachine
skip failing test suite (#197342)
f7f122c
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kertal
Copy link
Member

kertal commented Oct 23, 2024

Screen
Image

@kertal
Copy link
Member

kertal commented Oct 23, 2024

logs

[00:32:03]         │ debg TestSubjects.exists(lnsSuggestion-barVerticalStacked)
[00:32:03]         │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="lnsSuggestion-barVerticalStacked"]') with timeout=2500
[00:32:06]         │ debg --- retry.tryForTime error: [data-test-subj="lnsSuggestion-barVerticalStacked"] is not displayed - Attempt #: 0
[00:32:07]         │ debg TestSubjects.exists(lnsSuggestion-barVerticalStacked)
[00:32:07]         │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="lnsSuggestion-barVerticalStacked"]') with timeout=2500
[00:32:09]         │ debg --- retry.tryForTime error: [data-test-subj="lnsSuggestion-barVerticalStacked"] is not displayed - Attempt #: 0
[00:32:10]         │ debg TestSubjects.exists(lnsSuggestion-barVerticalStacked)
[00:32:10]         │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="lnsSuggestion-barVerticalStacked"]') with timeout=2500
[00:32:13]         │ debg --- retry.tryForTime error: [data-test-subj="lnsSuggestion-barVerticalStacked"] is not displayed - Attempt #: 0
[00:32:14]         │ debg TestSubjects.exists(lnsSuggestion-barVerticalStacked)
[00:32:14]         │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="lnsSuggestion-barVerticalStacked"]') with timeout=2500
[00:32:16]         │ debg --- retry.tryForTime error: [data-test-subj="lnsSuggestion-barVerticalStacked"] is not displayed - Attempt #: 0
[00:32:17]         │ debg TestSubjects.exists(lnsSuggestion-barVerticalStacked)
[00:32:17]         │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="lnsSuggestion-barVerticalStacked"]') with timeout=2500
[00:32:20]         │ debg --- retry.tryForTime error: [data-test-subj="lnsSuggestion-barVerticalStacked"] is not displayed - Attempt #: 0
[00:32:21]         │ debg TestSubjects.exists(lnsSuggestion-barVerticalStacked)
[00:32:21]         │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="lnsSuggestion-barVerticalStacked"]') with timeout=2500
[00:32:23]         │ debg --- retry.tryForTime error: [data-test-subj="lnsSuggestion-barVerticalStacked"] is not displayed - Attempt #: 0
[00:32:24]         │ info Taking window screenshot "/opt/buildkite-agent/builds/bk-agent-prod-gcp-1729631551825135577/elastic/kibana-on-merge/kibana/test/functional/screenshots/failure/discovergroup3 discover lens vis should be able to load a saved search with cust-df9d28ecde64a4a98c8e0fc3af3ab05689fd7fababe0862a772bd10d12513ebb.png"
[00:32:24]         │ info Current URL is: http://localhost:5620/app/discover#/view/94ca8022-431c-46fe-8846-17a27c1787db?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time:(from:%272015-09-19T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(columns:!(averageB,extension),dataSource:(type:esql),filters:!(),grid:(),hideChart:!f,interval:auto,query:(esql:%27from%20logstash-*%20%7C%20stats%20averageB%20%3D%20avg(bytes)%20by%20extension%27),sort:!(!(%27@timestamp%27,desc)),viewMode:documents)
[00:32:24]         │ info Saving page source to: /opt/buildkite-agent/builds/bk-agent-prod-gcp-1729631551825135577/elastic/kibana-on-merge/kibana/test/functional/failure_debug/html/discovergroup3 discover lens vis should be able to load a saved search with cust-df9d28ecde64a4a98c8e0fc3af3ab05689fd7fababe0862a772bd10d12513ebb.html
[00:32:24]         └- ✖ fail: discover/group3 discover lens vis should be able to load a saved search with custom vis, edit vis and revert changes
[00:32:24]         │      Error: timed out waiting for suggestion option
[00:32:24]         │       at onFailure (retry_for_truthy.ts:40:13)
[00:32:24]         │       at retryForSuccess (retry_for_success.ts:85:7)
[00:32:24]         │       at retryForTruthy (retry_for_truthy.ts:28:3)
[00:32:24]         │       at RetryService.waitFor (retry.ts:88:5)
[00:32:24]         │       at DiscoverPageObject.chooseLensSuggestion (discover_page.ts:257:5)
[00:32:24]         │       at Context.<anonymous> (_lens_vis.ts:618:7)
[00:32:24]         │       at Object.apply (wrap_function.js:74:16)

@kertal kertal self-assigned this Oct 23, 2024
@kertal
Copy link
Member

kertal commented Oct 23, 2024

dear @elastic/kibana-esql , seems this fails permanently

https://github.com/elastic/kibana/blob/f7f122c891f7a3678faa3883727bf85bff9adfb9/test/functional/apps/discover/group3/_lens_vis.ts#L619C1-L620C1

so it seems the vertical stacked bar chart is no longer availailable. do you have an idea why? Thx!

@stratoula
Copy link
Contributor

stratoula commented Oct 23, 2024 •
edited
Loading

I don't know tbh, I am not following so closely the Lens changes. @elastic/kibana-visualizations any idea what changed here maybe? Have you run it Matthias? How do the Lens suggestions look like? Can you send a screenshot?

Is this one? #197342 (comment)

If yes, then it seems that XY chart is not suggested anymore but I am not sure why tbh. Maybe the vis team has a clue though

@stratoula
Copy link
Contributor

I found it @markov00 @mbondyra it is due to this PR #197101

The metric is also suggested twice which is weird. Can you take a look?

@kertal
Copy link
Member

kertal commented Oct 23, 2024 •
edited
Loading

@stratoula a bit too late, since you already found it, but yes, I've run it, it looks like the screen I've added. 🙏 it's weird that this wasn't caught by CI when #197101 was merged! That's why I was thinking, maybe some ESQL change on ES side ... which would also be weird to not have been caught

@kertal kertal removed their assignment Oct 23, 2024
@kertal kertal added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Oct 23, 2024
@stratoula
Copy link
Contributor

stratoula commented Oct 23, 2024 •
edited
Loading

Yes it is weird and you should investigate it. (but still the problem is being caused by this PR, if you revert it it works fine)

@mbondyra mbondyra self-assigned this Oct 24, 2024
@mbondyra mbondyra mentioned this issue Oct 24, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 25, 2024
@mbondyra
[Discover] Fix suggestions for ES|QL charts (elastic#197583)
20778a4 
Fixes elastic#197342

In this PR (elastic#197101) I removed the
legacy metric from being suggested in the suggestion panel, and replaced
it with the new metric visualization. To maintain the previous behavior
in Lens (suggesting a new metric in the same place as legacy metric), we
made the score higher for the new metric. This positioned it higher also
in the Discover ESQL suggestions. This led to an issue where one
expected suggestion didn’t appear because we only display the top 6
suggestions by score and it got pushed out by metric.

Additionally, I made a change here to only display the metric without
bucketed columns in the suggestion panel. I don't see there's a lot of
value in suggesting bucketed metric unless it's something user chooses
intentionally.

Should be merged to 8.x after this:
elastic#197337

(cherry picked from commit b3b85da)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Fix suggestions for ES|QL charts mbondyra/kibana
6 participants
@kertal @jbudz @mbondyra @elasticmachine @stratoula @kibanamachine