Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15] [Canvas] Update kbn/flot to remove table.replace() issue (#195643) #197336

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Oct 22, 2024

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

@rshen91 rshen91 enabled auto-merge (squash) October 22, 2024 19:51
)

## Summary

Closing https://github.com/elastic/kibana-team/issues/1132 to avoid an
issue with Canvas, that is planned to be removed in 10.x. @kbn/flot is
being used by the monitoring team so I'm not removing it from Kibana in
this PR.

(cherry picked from commit 87bda29)

# Conflicts:
#	packages/kbn-flot-charts/lib/jquery_flot.js
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.1MB 1.1MB +1.8KB
monitoring 533.4KB 535.2KB +1.8KB
total +3.7KB

History

  • 💚 Build #244845 succeeded af8a452f35bdac35fb2e702fde9fb312ab667ec6

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rshen91 rshen91 merged commit 6d1b3d8 into elastic:8.15 Oct 23, 2024
20 checks passed
@rshen91 rshen91 deleted the backport/8.15/pr-195643 branch October 23, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants