[Fleet] Improve space selector validation when not providing valid space #197117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge upstream |
…ibana into fix-space-selector-validation
|
Starting backport for target branches: 8.15, 8.16, 8.x |
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
nchaulet
added
v8.16.0
backport:prev-minor
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 22, 2024
…ace (elastic#197117) (cherry picked from commit b668544)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 22, 2024
…ace (elastic#197117) (cherry picked from commit b668544)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 22, 2024
…lid space (#197117) (#197224) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Improve space selector validation when not providing valid space (#197117)](#197117) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T12:12:08Z","message":"[Fleet] Improve space selector validation when not providing valid space (#197117)","sha":"b668544406aa45df70c5c3e1f88ccf2b1c0eb140","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-major"],"title":"[Fleet] Improve space selector validation when not providing valid space","number":197117,"url":"https://github.com/elastic/kibana/pull/197117","mergeCommit":{"message":"[Fleet] Improve space selector validation when not providing valid space (#197117)","sha":"b668544406aa45df70c5c3e1f88ccf2b1c0eb140"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197117","number":197117,"mergeCommit":{"message":"[Fleet] Improve space selector validation when not providing valid space (#197117)","sha":"b668544406aa45df70c5c3e1f88ccf2b1c0eb140"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 22, 2024
…alid space (#197117) (#197223) # Backport This will backport the following commits from `main` to `8.16`: - [[Fleet] Improve space selector validation when not providing valid space (#197117)](#197117) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-22T12:12:08Z","message":"[Fleet] Improve space selector validation when not providing valid space (#197117)","sha":"b668544406aa45df70c5c3e1f88ccf2b1c0eb140","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-major"],"title":"[Fleet] Improve space selector validation when not providing valid space","number":197117,"url":"https://github.com/elastic/kibana/pull/197117","mergeCommit":{"message":"[Fleet] Improve space selector validation when not providing valid space (#197117)","sha":"b668544406aa45df70c5c3e1f88ccf2b1c0eb140"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197117","number":197117,"mergeCommit":{"message":"[Fleet] Improve space selector validation when not providing valid space (#197117)","sha":"b668544406aa45df70c5c3e1f88ccf2b1c0eb140"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #192547
Improve space selector validation to block the policy creation or update if the searched space is invalid
I added a unit test to cover that scenario