Hide assistant's knowledge base UI when assistantKnowledgeBaseByDefault feature flag is disabled
#196762
+33
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult` feature flag is disabled
e40pud
added
release_note:skip
patrykkopycinski
approved these changes
Oct 17, 2024
This reverts commit 52d18da.
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
cc @e40pud |
elena-shostak
approved these changes
Oct 18, 2024
|
Starting backport for target branches: 8.16 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
…ult` feature flag is disabled (elastic#196762) ## Summary This is the followup to elastic#195733 where we implemented the RBAC to allow managing Global Knowledge Base docs. With those changes we introduced a bug where we do not hide the RBAC configuration setting when `assistantKnowledgeBaseByDefault` feature flag is disabled. It means that in Serverless users will see this setting but it will do nothing for them. ### Screenshots of the fixed behaviour * `assistantKnowledgeBaseByDefault = true`  * `assistantKnowledgeBaseByDefault = false`  (cherry picked from commit f6e8065)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
…owledgeBaseByDefault` feature flag is disabled (#196762) (#196857) # Backport This will backport the following commits from `main` to `8.16`: - [Hide assistant's knowledge base UI when `assistantKnowledgeBaseByDefault` feature flag is disabled (#196762)](#196762) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T11:35:04Z","message":"Hide assistant's knowledge base UI when `assistantKnowledgeBaseByDefault` feature flag is disabled (#196762)\n\n## Summary\r\n\r\nThis is the followup to https://github.com/elastic/kibana/pull/195733\r\nwhere we implemented the RBAC to allow managing Global Knowledge Base\r\ndocs. With those changes we introduced a bug where we do not hide the\r\nRBAC configuration setting when `assistantKnowledgeBaseByDefault`\r\nfeature flag is disabled. It means that in Serverless users will see\r\nthis setting but it will do nothing for them.\r\n\r\n### Screenshots of the fixed behaviour\r\n\r\n* `assistantKnowledgeBaseByDefault = true`\r\n\r\n\r\n\r\n\r\n* `assistantKnowledgeBaseByDefault = false`\r\n\r\n\r\n","sha":"f6e8065dd75116ddf596b77f75a8468804008323","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:Security Assistant","Team:Security Generative AI","v8.16.0","backport:version"],"title":"Hide assistant's knowledge base UI when `assistantKnowledgeBaseByDefault` feature flag is disabled","number":196762,"url":"https://github.com/elastic/kibana/pull/196762","mergeCommit":{"message":"Hide assistant's knowledge base UI when `assistantKnowledgeBaseByDefault` feature flag is disabled (#196762)\n\n## Summary\r\n\r\nThis is the followup to https://github.com/elastic/kibana/pull/195733\r\nwhere we implemented the RBAC to allow managing Global Knowledge Base\r\ndocs. With those changes we introduced a bug where we do not hide the\r\nRBAC configuration setting when `assistantKnowledgeBaseByDefault`\r\nfeature flag is disabled. It means that in Serverless users will see\r\nthis setting but it will do nothing for them.\r\n\r\n### Screenshots of the fixed behaviour\r\n\r\n* `assistantKnowledgeBaseByDefault = true`\r\n\r\n\r\n\r\n\r\n* `assistantKnowledgeBaseByDefault = false`\r\n\r\n\r\n","sha":"f6e8065dd75116ddf596b77f75a8468804008323"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196762","number":196762,"mergeCommit":{"message":"Hide assistant's knowledge base UI when `assistantKnowledgeBaseByDefault` feature flag is disabled (#196762)\n\n## Summary\r\n\r\nThis is the followup to https://github.com/elastic/kibana/pull/195733\r\nwhere we implemented the RBAC to allow managing Global Knowledge Base\r\ndocs. With those changes we introduced a bug where we do not hide the\r\nRBAC configuration setting when `assistantKnowledgeBaseByDefault`\r\nfeature flag is disabled. It means that in Serverless users will see\r\nthis setting but it will do nothing for them.\r\n\r\n### Screenshots of the fixed behaviour\r\n\r\n* `assistantKnowledgeBaseByDefault = true`\r\n\r\n\r\n\r\n\r\n* `assistantKnowledgeBaseByDefault = false`\r\n\r\n\r\n","sha":"f6e8065dd75116ddf596b77f75a8468804008323"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
|
@e40pud there's a version gap with this backport. Can you check if this should also be backported to 8.x/8.17? |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
@jbudz thanks for catching this, I created a backport to 8.x #196980. Does that mean that this fix will not go into the next Serverless release on Monday? We were hoping to get it in. cc @peluja1012 |
e40pud
added a commit
to e40pud/kibana
that referenced
this pull request
Oct 19, 2024
…ult` feature flag is disabled (elastic#196762) ## Summary This is the followup to elastic#195733 where we implemented the RBAC to allow managing Global Knowledge Base docs. With those changes we introduced a bug where we do not hide the RBAC configuration setting when `assistantKnowledgeBaseByDefault` feature flag is disabled. It means that in Serverless users will see this setting but it will do nothing for them. ### Screenshots of the fixed behaviour * `assistantKnowledgeBaseByDefault = true`  * `assistantKnowledgeBaseByDefault = false`  (cherry picked from commit f6e8065)
It will, serverless releases from main (the commit merged from this PR). |
e40pud
added a commit
that referenced
this pull request
Oct 21, 2024
…ByDefault` feature flag is disabled (#196762) (#196980) # Backport This will backport the following commits from `main` to `8.x`: - [Hide assistant's knowledge base UI when `assistantKnowledgeBaseByDefault` feature flag is disabled (#196762)](#196762) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T11:35:04Z","message":"Hide assistant's knowledge base UI when `assistantKnowledgeBaseByDefault` feature flag is disabled (#196762)\n\n## Summary\r\n\r\nThis is the followup to https://github.com/elastic/kibana/pull/195733\r\nwhere we implemented the RBAC to allow managing Global Knowledge Base\r\ndocs. With those changes we introduced a bug where we do not hide the\r\nRBAC configuration setting when `assistantKnowledgeBaseByDefault`\r\nfeature flag is disabled. It means that in Serverless users will see\r\nthis setting but it will do nothing for them.\r\n\r\n### Screenshots of the fixed behaviour\r\n\r\n* `assistantKnowledgeBaseByDefault = true`\r\n\r\n\r\n\r\n\r\n* `assistantKnowledgeBaseByDefault = false`\r\n\r\n\r\n","sha":"f6e8065dd75116ddf596b77f75a8468804008323","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:Security Assistant","Team:Security Generative AI","v8.16.0","backport:version"],"number":196762,"url":"https://github.com/elastic/kibana/pull/196762","mergeCommit":{"message":"Hide assistant's knowledge base UI when `assistantKnowledgeBaseByDefault` feature flag is disabled (#196762)\n\n## Summary\r\n\r\nThis is the followup to https://github.com/elastic/kibana/pull/195733\r\nwhere we implemented the RBAC to allow managing Global Knowledge Base\r\ndocs. With those changes we introduced a bug where we do not hide the\r\nRBAC configuration setting when `assistantKnowledgeBaseByDefault`\r\nfeature flag is disabled. It means that in Serverless users will see\r\nthis setting but it will do nothing for them.\r\n\r\n### Screenshots of the fixed behaviour\r\n\r\n* `assistantKnowledgeBaseByDefault = true`\r\n\r\n\r\n\r\n\r\n* `assistantKnowledgeBaseByDefault = false`\r\n\r\n\r\n","sha":"f6e8065dd75116ddf596b77f75a8468804008323"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196762","number":196762,"mergeCommit":{"message":"Hide assistant's knowledge base UI when `assistantKnowledgeBaseByDefault` feature flag is disabled (#196762)\n\n## Summary\r\n\r\nThis is the followup to https://github.com/elastic/kibana/pull/195733\r\nwhere we implemented the RBAC to allow managing Global Knowledge Base\r\ndocs. With those changes we introduced a bug where we do not hide the\r\nRBAC configuration setting when `assistantKnowledgeBaseByDefault`\r\nfeature flag is disabled. It means that in Serverless users will see\r\nthis setting but it will do nothing for them.\r\n\r\n### Screenshots of the fixed behaviour\r\n\r\n* `assistantKnowledgeBaseByDefault = true`\r\n\r\n\r\n\r\n\r\n* `assistantKnowledgeBaseByDefault = false`\r\n\r\n\r\n","sha":"f6e8065dd75116ddf596b77f75a8468804008323"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196857","number":196857,"state":"MERGED","mergeCommit":{"sha":"8094dd6d7791a5fd6e8ead925a1ba42b6bb7acfa","message":"[8.16] Hide assistant's knowledge base UI when `assistantKnowledgeBaseByDefault` feature flag is disabled (#196762) (#196857)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.16`:\n- [Hide assistant's knowledge base UI when\n`assistantKnowledgeBaseByDefault` feature flag is disabled\n(#196762)](https://github.com/elastic/kibana/pull/196762)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Ievgen\nSorokopud\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-18T11:35:04Z\",\"message\":\"Hide\nassistant's knowledge base UI when `assistantKnowledgeBaseByDefault`\nfeature flag is disabled (#196762)\\n\\n## Summary\\r\\n\\r\\nThis is the\nfollowup to https://github.com/elastic/kibana/pull/195733\\r\\nwhere we\nimplemented the RBAC to allow managing Global Knowledge Base\\r\\ndocs.\nWith those changes we introduced a bug where we do not hide the\\r\\nRBAC\nconfiguration setting when `assistantKnowledgeBaseByDefault`\\r\\nfeature\nflag is disabled. It means that in Serverless users will see\\r\\nthis\nsetting but it will do nothing for them.\\r\\n\\r\\n### Screenshots of the\nfixed behaviour\\r\\n\\r\\n* `assistantKnowledgeBaseByDefault =\ntrue`\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n*\n`assistantKnowledgeBaseByDefault =\nfalse`\\r\\n\\r\\n\\r\\n\",\"sha\":\"f6e8065dd75116ddf596b77f75a8468804008323\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Feature:Security\nAssistant\",\"Team:Security Generative\nAI\",\"v8.16.0\",\"backport:version\"],\"title\":\"Hide assistant's knowledge\nbase UI when `assistantKnowledgeBaseByDefault` feature flag is\ndisabled\",\"number\":196762,\"url\":\"https://github.com/elastic/kibana/pull/196762\",\"mergeCommit\":{\"message\":\"Hide\nassistant's knowledge base UI when `assistantKnowledgeBaseByDefault`\nfeature flag is disabled (#196762)\\n\\n## Summary\\r\\n\\r\\nThis is the\nfollowup to https://github.com/elastic/kibana/pull/195733\\r\\nwhere we\nimplemented the RBAC to allow managing Global Knowledge Base\\r\\ndocs.\nWith those changes we introduced a bug where we do not hide the\\r\\nRBAC\nconfiguration setting when `assistantKnowledgeBaseByDefault`\\r\\nfeature\nflag is disabled. It means that in Serverless users will see\\r\\nthis\nsetting but it will do nothing for them.\\r\\n\\r\\n### Screenshots of the\nfixed behaviour\\r\\n\\r\\n* `assistantKnowledgeBaseByDefault =\ntrue`\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n*\n`assistantKnowledgeBaseByDefault =\nfalse`\\r\\n\\r\\n\\r\\n\",\"sha\":\"f6e8065dd75116ddf596b77f75a8468804008323\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196762\",\"number\":196762,\"mergeCommit\":{\"message\":\"Hide\nassistant's knowledge base UI when `assistantKnowledgeBaseByDefault`\nfeature flag is disabled (#196762)\\n\\n## Summary\\r\\n\\r\\nThis is the\nfollowup to https://github.com/elastic/kibana/pull/195733\\r\\nwhere we\nimplemented the RBAC to allow managing Global Knowledge Base\\r\\ndocs.\nWith those changes we introduced a bug where we do not hide the\\r\\nRBAC\nconfiguration setting when `assistantKnowledgeBaseByDefault`\\r\\nfeature\nflag is disabled. It means that in Serverless users will see\\r\\nthis\nsetting but it will do nothing for them.\\r\\n\\r\\n### Screenshots of the\nfixed behaviour\\r\\n\\r\\n* `assistantKnowledgeBaseByDefault =\ntrue`\\r\\n\\r\\n\\r\\n\\r\\n\\r\\n*\n`assistantKnowledgeBaseByDefault =\nfalse`\\r\\n\\r\\n\\r\\n\",\"sha\":\"f6e8065dd75116ddf596b77f75a8468804008323\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Ievgen Sorokopud <[email protected]>"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the followup to #195733 where we implemented the RBAC to allow managing Global Knowledge Base docs. With those changes we introduced a bug where we do not hide the RBAC configuration setting when
assistantKnowledgeBaseByDefaultfeature flag is disabled. It means that in Serverless users will see this setting but it will do nothing for them.Screenshots of the fixed behaviour
assistantKnowledgeBaseByDefault = trueassistantKnowledgeBaseByDefault = false