Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLO] Bring back the create drilldown menu option in SLO embeddable #196740

Closed
maryam-saeidi opened this issue Oct 17, 2024 · 3 comments · Fixed by #201870
Closed

[SLO] Bring back the create drilldown menu option in SLO embeddable #196740

maryam-saeidi opened this issue Oct 17, 2024 · 3 comments · Fixed by #201870
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:SLO Team:obs-ux-management Observability Management User Experience Team

Comments

@maryam-saeidi
Copy link
Member

Kibana version: 8.15.1

Elasticsearch version:

Server OS version:

Browser version:

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):

Describe the bug:

As shown below, previously we had a create drilldown option available in the SLO embeddable but this option is not there any more.

8.14.1 8.15.1
Image Image

This might be a regression that was introduced in #181930. In this ticket, we want to fix not having that option in the SLO embeddable menu.

Implementation hint

Provided by @Heenawter

If you take a look at the isCompatible method of the FlyoutCreateDrilldownAction, you should be able to determine which part of the API your embeddable is missing to make the "Create drilldown" action incompatible. if I had to guess, it is most likely either HasDynamicActions or HasSupportedTriggers that is missing (or possibly both) - you can take a look at how the Visualize embeddable supports drilldowns in src/plugins/visualizations/public/embeddable/visualize_embeddable.tsx, where they make use of the initializeReactEmbeddableDynamicActions function we provide through the EmbeddableEnhanced plugin start contract.

Acceptance criteria

  • Bring back the create drilldown menu option for the SLO embeddable
@maryam-saeidi maryam-saeidi added bug Fixes for quality problems that affect the customer experience Feature:SLO Team:obs-ux-management Observability Management User Experience Team labels Oct 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kdelemme
Copy link
Contributor

I'm struggling with adding the dependency to embeddableEnhanced from the slo plugin

Image

@kdelemme
Copy link
Contributor

Fixed the previous error by changing the visibility of the embeddable-enhanced plugin to shared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:SLO Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants