Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObsUx] Remove feature flags enabled by default #196736

Closed
2 tasks done
jennypavlova opened this issue Oct 17, 2024 · 4 comments
Closed
2 tasks done

[ObsUx] Remove feature flags enabled by default #196736

jennypavlova opened this issue Oct 17, 2024 · 4 comments
Labels
discuss needs-refinement A reason and acceptance criteria need to be defined for this issue Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture

Comments

@jennypavlova
Copy link
Member

jennypavlova commented Oct 17, 2024

Summary

We have some feature flags that are enabled by default. Those settings can be removed and marked as deprecated.

The list of the configs I found (we need to double check and decide if we want to remove all/some of them):

  • observability:apmTraceExplorerTab (Tech Preview: enabled by default)
  • observability:apmEnableTableSearchBar (Beta: enabled by default)
  • observability:apmEnableServiceInventoryTableSearchBar (Tech Preview: enabled by default)
  • observability:apmTraceExplorerTab (Tech Preview: enabled by default)

No longer beta/tech preview

  • observability:enableInfrastructureHostsView (No longer beta: enabled by default)

  • observability:enableInfrastructureContainerAssetView (No longer beta: enabled by default)

Questions/Notes

  • Any documentation update needed: should we add follow-up issues
  • What is the right approach to mark them as deprecated (or should we remove them completely)?
  • Good way to test the version update

AC

  • Make sure the feature flags are no longer used in the codebase
  • Update any usage in the code (tests as well)
  • Make sure that if the flags are set in an older version there are no errors after an update to v9
@jennypavlova jennypavlova added discuss needs-refinement A reason and acceptance criteria need to be defined for this issue Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture labels Oct 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@smith
Copy link
Contributor

smith commented Oct 17, 2024

We might want to make decisions on a case-by-case basis which items to remove here. For the items that are no longer beta we should remove the setting. We should decide which items we want to promote from beta to GA or tech preview to beta or GA, etc.

@jennypavlova
Copy link
Member Author

@smith Thanks for checking that!

For the items that are no longer beta we should remove the setting.

Agree, I added a subtask for that and I will remove them 👍

We should decide which items we want to promote from beta to GA or tech preview to beta or GA, etc.

I will keep the list in this issue in case we want to check those and decide (maybe here or as a follow-up in the future)

@jennypavlova
Copy link
Member Author

Closing this for now as the other feature flags won't be removed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss needs-refinement A reason and acceptance criteria need to be defined for this issue Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

3 participants