Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Pipelines] Improve api integration tests #196718

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

ElenaStoeva
Copy link
Contributor

@ElenaStoeva ElenaStoeva commented Oct 17, 2024

Follow-up to #190830

Summary

I noticed that the api integration tests that have been added with #190830 were not actually included to run as part of the Management test suite. This PR adds them and it also adds some test cases for the ipinfo database type.

@ElenaStoeva ElenaStoeva added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test-api-integration Feature:Ingest Node Pipelines Ingest node pipelines management backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 17, 2024
@ElenaStoeva ElenaStoeva self-assigned this Oct 17, 2024
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner October 17, 2024 14:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@ElenaStoeva ElenaStoeva added the release_note:skip Skip the PR/issue when compiling release notes label Oct 17, 2024
@ElenaStoeva ElenaStoeva requested a review from mattkime October 17, 2024 16:09
@mattkime mattkime added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 17, 2024
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, make sure they're manually backported to 8.16

@ElenaStoeva ElenaStoeva enabled auto-merge (squash) October 17, 2024 16:18
@ElenaStoeva ElenaStoeva merged commit 727c19a into elastic:main Oct 17, 2024
40 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11390163710

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @ElenaStoeva

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 17, 2024
Follow-up to elastic#190830

## Summary

I noticed that the api integration tests that have been added with
elastic#190830 were not actually included
to run as part of the Management test suite. This PR adds them and it
also adds some test cases for the `ipinfo` database type.

(cherry picked from commit 727c19a)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 17, 2024
Follow-up to elastic#190830

## Summary

I noticed that the api integration tests that have been added with
elastic#190830 were not actually included
to run as part of the Management test suite. This PR adds them and it
also adds some test cases for the `ipinfo` database type.

(cherry picked from commit 727c19a)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 17, 2024
…96749)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Ingest Pipelines] Improve api integration tests
(#196718)](#196718)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Elena
Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T17:40:21Z","message":"[Ingest
Pipelines] Improve api integration tests (#196718)\n\nFollow-up to
https://github.com/elastic/kibana/pull/190830\r\n\r\n## Summary\r\n\r\nI
noticed that the api integration tests that have been added
with\r\nhttps://github.com//pull/190830 were not actually
included\r\nto run as part of the Management test suite. This PR adds
them and it\r\nalso adds some test cases for the `ipinfo` database
type.","sha":"727c19a78bf7831da150e84ffb06abf6db6878bc","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","test-api-integration","v9.0.0","Feature:Ingest
Node
Pipelines","backport:prev-minor","v8.16.0","v8.17.0"],"title":"[Ingest
Pipelines] Improve api integration
tests","number":196718,"url":"https://github.com/elastic/kibana/pull/196718","mergeCommit":{"message":"[Ingest
Pipelines] Improve api integration tests (#196718)\n\nFollow-up to
https://github.com/elastic/kibana/pull/190830\r\n\r\n## Summary\r\n\r\nI
noticed that the api integration tests that have been added
with\r\nhttps://github.com//pull/190830 were not actually
included\r\nto run as part of the Management test suite. This PR adds
them and it\r\nalso adds some test cases for the `ipinfo` database
type.","sha":"727c19a78bf7831da150e84ffb06abf6db6878bc"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196718","number":196718,"mergeCommit":{"message":"[Ingest
Pipelines] Improve api integration tests (#196718)\n\nFollow-up to
https://github.com/elastic/kibana/pull/190830\r\n\r\n## Summary\r\n\r\nI
noticed that the api integration tests that have been added
with\r\nhttps://github.com//pull/190830 were not actually
included\r\nto run as part of the Management test suite. This PR adds
them and it\r\nalso adds some test cases for the `ipinfo` database
type.","sha":"727c19a78bf7831da150e84ffb06abf6db6878bc"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Elena Stoeva <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 17, 2024
…6750)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Ingest Pipelines] Improve api integration tests
(#196718)](#196718)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Elena
Stoeva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T17:40:21Z","message":"[Ingest
Pipelines] Improve api integration tests (#196718)\n\nFollow-up to
https://github.com/elastic/kibana/pull/190830\r\n\r\n## Summary\r\n\r\nI
noticed that the api integration tests that have been added
with\r\nhttps://github.com//pull/190830 were not actually
included\r\nto run as part of the Management test suite. This PR adds
them and it\r\nalso adds some test cases for the `ipinfo` database
type.","sha":"727c19a78bf7831da150e84ffb06abf6db6878bc","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","test-api-integration","v9.0.0","Feature:Ingest
Node
Pipelines","backport:prev-minor","v8.16.0","v8.17.0"],"title":"[Ingest
Pipelines] Improve api integration
tests","number":196718,"url":"https://github.com/elastic/kibana/pull/196718","mergeCommit":{"message":"[Ingest
Pipelines] Improve api integration tests (#196718)\n\nFollow-up to
https://github.com/elastic/kibana/pull/190830\r\n\r\n## Summary\r\n\r\nI
noticed that the api integration tests that have been added
with\r\nhttps://github.com//pull/190830 were not actually
included\r\nto run as part of the Management test suite. This PR adds
them and it\r\nalso adds some test cases for the `ipinfo` database
type.","sha":"727c19a78bf7831da150e84ffb06abf6db6878bc"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196718","number":196718,"mergeCommit":{"message":"[Ingest
Pipelines] Improve api integration tests (#196718)\n\nFollow-up to
https://github.com/elastic/kibana/pull/190830\r\n\r\n## Summary\r\n\r\nI
noticed that the api integration tests that have been added
with\r\nhttps://github.com//pull/190830 were not actually
included\r\nto run as part of the Management test suite. This PR adds
them and it\r\nalso adds some test cases for the `ipinfo` database
type.","sha":"727c19a78bf7831da150e84ffb06abf6db6878bc"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Elena Stoeva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test-api-integration v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants