Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution][Onboarding] Integration cards missing from the Recommended tab #196649

Closed
angorayc opened this issue Oct 17, 2024 · 3 comments
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Threat Hunting:Explore v8.16.0

Comments

@angorayc
Copy link
Contributor

angorayc commented Oct 17, 2024

Kibana version: 8.16

Integration cards missing from the Recommended tab on a cloud deployment (https://p.elstc.co/paste/+6OYqx41#tZxjvqXgQJ2uRlCSqZH8ADMEAvR1+qnXe-5kEbt+bro):

Current (on a deployment):
Image

Expected:
Image

Integration cards missing due to Fleet packages api has different behaviour on a cloud deployment:
One of the api returns less items than expected on a cloud deployment.
Furthermore, the id can be modified during the merging process, might not be an ideal key to locate the feature cards, whereas title has never been mismatched or changed during the merging process, it should be consistent between the api result and the final result.

@angorayc angorayc added bug Fixes for quality problems that affect the customer experience Team:Threat Hunting:Explore v8.16.0 labels Oct 17, 2024
@angorayc angorayc self-assigned this Oct 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@angorayc
Copy link
Contributor Author

angorayc commented Oct 17, 2024

Update There are still some integration cards not available after deploying to the cloud:

The local integration counts is 404, but the cloud version has only 169. This causes some of the recommended integrations on the onboarding hub are still missing:

Local:
Image

Cloud: https://p.elstc.co/paste/+6OYqx41#tZxjvqXgQJ2uRlCSqZH8ADMEAvR1+qnXe-5kEbt+bro
Image

@angorayc
Copy link
Contributor Author

angorayc added a commit that referenced this issue Oct 21, 2024
## Summary

Fixes: #196091 |
~#196649

1. Add the error handling when an error occurred during check complete.
2. Update the AI assistant capabilities to
`[['securitySolutionAssistant.ai-assistant', 'actions.show']]`

**Steps to verify:**


https://p.elstc.co/paste/+6OYqx41#tZxjvqXgQJ2uRlCSqZH8ADMEAvR1+qnXe-5kEbt+bro
Login with the user without indices privilege. It should display the tab
content without the completion information.

When completion check failed - it should display and error `toast`,
regard the card as `incomplete` and `show the content`:



https://github.com/user-attachments/assets/30b1654e-99cc-4582-8beb-c4a5fb005e6f

AI assistant should not show connectors options as `add integration` is
regarded as incomplete:

<img width="1761" alt="Screenshot 2024-10-17 at 15 02 42"
src="https://github.com/user-attachments/assets/07fb317e-57d6-4980-aae3-7eb2d0fce12a">


Then add the index privilege:
<img width="2208" alt="Screenshot 2024-10-17 at 15 07 36"
src="https://github.com/user-attachments/assets/bb879964-e31b-4ee3-8eb3-dff0381be287">

When completion check success: it should display the completion results:



https://github.com/user-attachments/assets/2a27a042-c634-4f44-bfd0-2ae503f396a2



Set `actions and connectors` to read only:
<img width="779" alt="Screenshot 2024-10-17 at 15 04 28"
src="https://github.com/user-attachments/assets/098b0c90-30a9-4e82-ad16-10d2cd64a9cc">


<img width="1250" alt="Screenshot 2024-10-17 at 16 40 18"
src="https://github.com/user-attachments/assets/5e677d5a-32b8-4cea-b240-207a3f055f9c">







### Checklist

Delete any items that are not applicable to this PR.


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 21, 2024
…c#196389)

## Summary

Fixes: elastic#196091 |
~elastic#196649

1. Add the error handling when an error occurred during check complete.
2. Update the AI assistant capabilities to
`[['securitySolutionAssistant.ai-assistant', 'actions.show']]`

**Steps to verify:**

https://p.elstc.co/paste/+6OYqx41#tZxjvqXgQJ2uRlCSqZH8ADMEAvR1+qnXe-5kEbt+bro
Login with the user without indices privilege. It should display the tab
content without the completion information.

When completion check failed - it should display and error `toast`,
regard the card as `incomplete` and `show the content`:

https://github.com/user-attachments/assets/30b1654e-99cc-4582-8beb-c4a5fb005e6f

AI assistant should not show connectors options as `add integration` is
regarded as incomplete:

<img width="1761" alt="Screenshot 2024-10-17 at 15 02 42"
src="https://github.com/user-attachments/assets/07fb317e-57d6-4980-aae3-7eb2d0fce12a">

Then add the index privilege:
<img width="2208" alt="Screenshot 2024-10-17 at 15 07 36"
src="https://github.com/user-attachments/assets/bb879964-e31b-4ee3-8eb3-dff0381be287">

When completion check success: it should display the completion results:

https://github.com/user-attachments/assets/2a27a042-c634-4f44-bfd0-2ae503f396a2

Set `actions and connectors` to read only:
<img width="779" alt="Screenshot 2024-10-17 at 15 04 28"
src="https://github.com/user-attachments/assets/098b0c90-30a9-4e82-ad16-10d2cd64a9cc">

<img width="1250" alt="Screenshot 2024-10-17 at 16 40 18"
src="https://github.com/user-attachments/assets/5e677d5a-32b8-4cea-b240-207a3f055f9c">

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 10ec204)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 21, 2024
…c#196389)

## Summary

Fixes: elastic#196091 |
~elastic#196649

1. Add the error handling when an error occurred during check complete.
2. Update the AI assistant capabilities to
`[['securitySolutionAssistant.ai-assistant', 'actions.show']]`

**Steps to verify:**

https://p.elstc.co/paste/+6OYqx41#tZxjvqXgQJ2uRlCSqZH8ADMEAvR1+qnXe-5kEbt+bro
Login with the user without indices privilege. It should display the tab
content without the completion information.

When completion check failed - it should display and error `toast`,
regard the card as `incomplete` and `show the content`:

https://github.com/user-attachments/assets/30b1654e-99cc-4582-8beb-c4a5fb005e6f

AI assistant should not show connectors options as `add integration` is
regarded as incomplete:

<img width="1761" alt="Screenshot 2024-10-17 at 15 02 42"
src="https://github.com/user-attachments/assets/07fb317e-57d6-4980-aae3-7eb2d0fce12a">

Then add the index privilege:
<img width="2208" alt="Screenshot 2024-10-17 at 15 07 36"
src="https://github.com/user-attachments/assets/bb879964-e31b-4ee3-8eb3-dff0381be287">

When completion check success: it should display the completion results:

https://github.com/user-attachments/assets/2a27a042-c634-4f44-bfd0-2ae503f396a2

Set `actions and connectors` to read only:
<img width="779" alt="Screenshot 2024-10-17 at 15 04 28"
src="https://github.com/user-attachments/assets/098b0c90-30a9-4e82-ad16-10d2cd64a9cc">

<img width="1250" alt="Screenshot 2024-10-17 at 16 40 18"
src="https://github.com/user-attachments/assets/5e677d5a-32b8-4cea-b240-207a3f055f9c">

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 10ec204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Threat Hunting:Explore v8.16.0
Projects
None yet
Development

No branches or pull requests

2 participants