[Security Solution] Document details flyout - update insight KPI count #196617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
added
backport
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
desk tested and code LGTM. I left 3 extremely minor comments. Amazing turn around on this, awesome job @christineweng!
Let's wait on the UIUX team to confirm the patterns, but as soon as we get their green light let's merge this!
...s/security_solution/public/flyout/document_details/shared/components/alert_count_insight.tsx
Outdated
Show resolved
Hide resolved
...urity_solution/public/flyout/document_details/shared/components/misconfiguration_insight.tsx
Outdated
Show resolved
Hide resolved
...curity_solution/public/flyout/document_details/shared/components/vulnerabilities_insight.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2024
elastic#196617) ## Summary This PR made some updates to the insights KPI following elastic#195509 - Updated all the counts to be total alerts/misconfigurations/vulnerabilities - Clicking on the count badge opens timeline (alerts) or entity preview - Revert the order of the distribution bar for alerts to align with others https://github.com/user-attachments/assets/6d65503a-26b1-4db4-9118-a63ad66ac7b6 Latest design  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 7195141)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2024
elastic#196617) ## Summary This PR made some updates to the insights KPI following elastic#195509 - Updated all the counts to be total alerts/misconfigurations/vulnerabilities - Clicking on the count badge opens timeline (alerts) or entity preview - Revert the order of the distribution bar for alerts to align with others https://github.com/user-attachments/assets/6d65503a-26b1-4db4-9118-a63ad66ac7b6 Latest design  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 7195141)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
…PI count (#196617) (#196779) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution] Document details flyout - update insight KPI count (#196617)](#196617) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T22:57:52Z","message":"[Security Solution] Document details flyout - update insight KPI count (#196617)\n\n## Summary\r\n\r\nThis PR made some updates to the insights KPI following\r\nhttps://github.com//pull/195509\r\n\r\n- Updated all the counts to be total\r\nalerts/misconfigurations/vulnerabilities\r\n- Clicking on the count badge opens timeline (alerts) or entity preview\r\n- Revert the order of the distribution bar for alerts to align with\r\nothers\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6d65503a-26b1-4db4-9118-a63ad66ac7b6\r\n\r\nLatest design\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"71951416ca045cf0d2fee74d88faa0f717f487c6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution] Document details flyout - update insight KPI count","number":196617,"url":"https://github.com/elastic/kibana/pull/196617","mergeCommit":{"message":"[Security Solution] Document details flyout - update insight KPI count (#196617)\n\n## Summary\r\n\r\nThis PR made some updates to the insights KPI following\r\nhttps://github.com//pull/195509\r\n\r\n- Updated all the counts to be total\r\nalerts/misconfigurations/vulnerabilities\r\n- Clicking on the count badge opens timeline (alerts) or entity preview\r\n- Revert the order of the distribution bar for alerts to align with\r\nothers\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6d65503a-26b1-4db4-9118-a63ad66ac7b6\r\n\r\nLatest design\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"71951416ca045cf0d2fee74d88faa0f717f487c6"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196617","number":196617,"mergeCommit":{"message":"[Security Solution] Document details flyout - update insight KPI count (#196617)\n\n## Summary\r\n\r\nThis PR made some updates to the insights KPI following\r\nhttps://github.com//pull/195509\r\n\r\n- Updated all the counts to be total\r\nalerts/misconfigurations/vulnerabilities\r\n- Clicking on the count badge opens timeline (alerts) or entity preview\r\n- Revert the order of the distribution bar for alerts to align with\r\nothers\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6d65503a-26b1-4db4-9118-a63ad66ac7b6\r\n\r\nLatest design\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"71951416ca045cf0d2fee74d88faa0f717f487c6"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
…I count (#196617) (#196780) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Document details flyout - update insight KPI count (#196617)](#196617) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T22:57:52Z","message":"[Security Solution] Document details flyout - update insight KPI count (#196617)\n\n## Summary\r\n\r\nThis PR made some updates to the insights KPI following\r\nhttps://github.com//pull/195509\r\n\r\n- Updated all the counts to be total\r\nalerts/misconfigurations/vulnerabilities\r\n- Clicking on the count badge opens timeline (alerts) or entity preview\r\n- Revert the order of the distribution bar for alerts to align with\r\nothers\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6d65503a-26b1-4db4-9118-a63ad66ac7b6\r\n\r\nLatest design\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"71951416ca045cf0d2fee74d88faa0f717f487c6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution] Document details flyout - update insight KPI count","number":196617,"url":"https://github.com/elastic/kibana/pull/196617","mergeCommit":{"message":"[Security Solution] Document details flyout - update insight KPI count (#196617)\n\n## Summary\r\n\r\nThis PR made some updates to the insights KPI following\r\nhttps://github.com//pull/195509\r\n\r\n- Updated all the counts to be total\r\nalerts/misconfigurations/vulnerabilities\r\n- Clicking on the count badge opens timeline (alerts) or entity preview\r\n- Revert the order of the distribution bar for alerts to align with\r\nothers\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6d65503a-26b1-4db4-9118-a63ad66ac7b6\r\n\r\nLatest design\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"71951416ca045cf0d2fee74d88faa0f717f487c6"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196617","number":196617,"mergeCommit":{"message":"[Security Solution] Document details flyout - update insight KPI count (#196617)\n\n## Summary\r\n\r\nThis PR made some updates to the insights KPI following\r\nhttps://github.com//pull/195509\r\n\r\n- Updated all the counts to be total\r\nalerts/misconfigurations/vulnerabilities\r\n- Clicking on the count badge opens timeline (alerts) or entity preview\r\n- Revert the order of the distribution bar for alerts to align with\r\nothers\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6d65503a-26b1-4db4-9118-a63ad66ac7b6\r\n\r\nLatest design\r\n\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"71951416ca045cf0d2fee74d88faa0f717f487c6"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR made some updates to the insights KPI following #195509
Screen.Recording.2024-10-16.at.4.49.35.PM.mov
Latest design
Checklist