-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Data Quality Dashboard][ESS] Check state reset on ilm phase change #196523
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Data Health Quality
Data health quality dashboard and related features
fixed
Team:Threat Hunting:Explore
Team:Threat Hunting
Security Solution Threat Hunting Team
v8.16.1
v8.17.0
v9.0.0
Comments
kapral18
added
bug
Fixes for quality problems that affect the customer experience
Feature:Data Health Quality
Data health quality dashboard and related features
Team:Threat Hunting
Security Solution Threat Hunting Team
Team:Threat Hunting:Explore
labels
Oct 16, 2024
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
kapral18
changed the title
[SecuritySolution][DataQualityDashboard] Check state reset on ilm phase change
[Security Solution][Data Quality Dashboard] Check state reset on ilm phase change
Oct 22, 2024
kapral18
added a commit
to kapral18/kibana
that referenced
this issue
Oct 31, 2024
…n ilm phase filter change addresses elastic#196523
kapral18
added a commit
to kapral18/kibana
that referenced
this issue
Oct 31, 2024
…n ilm phase filter change addresses elastic#196523
kapral18
added a commit
to kapral18/kibana
that referenced
this issue
Nov 4, 2024
…n ilm phase filter change addresses elastic#196523
kapral18
added a commit
to kapral18/kibana
that referenced
this issue
Nov 4, 2024
…n ilm phase filter change addresses elastic#196523
kapral18
added a commit
to kapral18/kibana
that referenced
this issue
Nov 4, 2024
…n ilm phase filter change addresses elastic#196523
kapral18
added a commit
to kapral18/kibana
that referenced
this issue
Nov 4, 2024
…n ilm phase filter change addresses elastic#196523
kapral18
added a commit
to kapral18/kibana
that referenced
this issue
Nov 4, 2024
…n ilm phase filter change addresses elastic#196523
kapral18
added a commit
to kapral18/kibana
that referenced
this issue
Nov 4, 2024
…n ilm phase filter change addresses elastic#196523
kapral18
added a commit
that referenced
this issue
Nov 4, 2024
…n ilm phase filter change (#198549) addresses #196523 - Fixes ilm phase change propagation on patterns. - Adds missing tests for useResultsRollup functionality ## UI changes ### Before https://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017 ### After https://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 4, 2024
…n ilm phase filter change (elastic#198549) addresses elastic#196523 - Fixes ilm phase change propagation on patterns. - Adds missing tests for useResultsRollup functionality ## UI changes ### Before https://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017 ### After https://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4 (cherry picked from commit ddf55ea)
kibanamachine
added a commit
that referenced
this issue
Nov 7, 2024
…eset on ilm phase filter change (#198549) (#198806) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Data Quality Dashboard] fix pattern state reset on ilm phase filter change (#198549)](#198549) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Karen Grigoryan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T15:09:12Z","message":"[Security Solution][Data Quality Dashboard] fix pattern state reset on ilm phase filter change (#198549)\n\naddresses #196523\r\n\r\n- Fixes ilm phase change propagation on patterns.\r\n- Adds missing tests for useResultsRollup functionality\r\n\r\n## UI changes\r\n\r\n### Before\r\n\r\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\r\n\r\n### After\r\n\r\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4","sha":"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Explore","backport:prev-minor","ci:cloud-deploy","ci:project-deploy-security"],"title":"[Security Solution][Data Quality Dashboard] fix pattern state reset on ilm phase filter change","number":198549,"url":"https://github.com/elastic/kibana/pull/198549","mergeCommit":{"message":"[Security Solution][Data Quality Dashboard] fix pattern state reset on ilm phase filter change (#198549)\n\naddresses #196523\r\n\r\n- Fixes ilm phase change propagation on patterns.\r\n- Adds missing tests for useResultsRollup functionality\r\n\r\n## UI changes\r\n\r\n### Before\r\n\r\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\r\n\r\n### After\r\n\r\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4","sha":"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198549","number":198549,"mergeCommit":{"message":"[Security Solution][Data Quality Dashboard] fix pattern state reset on ilm phase filter change (#198549)\n\naddresses #196523\r\n\r\n- Fixes ilm phase change propagation on patterns.\r\n- Adds missing tests for useResultsRollup functionality\r\n\r\n## UI changes\r\n\r\n### Before\r\n\r\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\r\n\r\n### After\r\n\r\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4","sha":"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9"}}]}] BACKPORT--> Co-authored-by: Karen Grigoryan <[email protected]>
kapral18
added a commit
to kapral18/kibana
that referenced
this issue
Nov 18, 2024
…n ilm phase filter change (elastic#198549) addresses elastic#196523 - Fixes ilm phase change propagation on patterns. - Adds missing tests for useResultsRollup functionality ## UI changes ### Before https://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017 ### After https://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4 (cherry picked from commit ddf55ea)
kapral18
added a commit
that referenced
this issue
Nov 18, 2024
…reset on ilm phase filter change (#198549) (#200618) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution][Data Quality Dashboard] fix pattern state reset on ilm phase filter change (#198549)](#198549) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Karen Grigoryan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T15:09:12Z","message":"[Security Solution][Data Quality Dashboard] fix pattern state reset on ilm phase filter change (#198549)\n\naddresses #196523\r\n\r\n- Fixes ilm phase change propagation on patterns.\r\n- Adds missing tests for useResultsRollup functionality\r\n\r\n## UI changes\r\n\r\n### Before\r\n\r\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\r\n\r\n### After\r\n\r\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4","sha":"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Explore","backport:prev-minor","ci:cloud-deploy","ci:project-deploy-security","v8.17.0"],"number":198549,"url":"https://github.com/elastic/kibana/pull/198549","mergeCommit":{"message":"[Security Solution][Data Quality Dashboard] fix pattern state reset on ilm phase filter change (#198549)\n\naddresses #196523\r\n\r\n- Fixes ilm phase change propagation on patterns.\r\n- Adds missing tests for useResultsRollup functionality\r\n\r\n## UI changes\r\n\r\n### Before\r\n\r\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\r\n\r\n### After\r\n\r\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4","sha":"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198549","number":198549,"mergeCommit":{"message":"[Security Solution][Data Quality Dashboard] fix pattern state reset on ilm phase filter change (#198549)\n\naddresses #196523\r\n\r\n- Fixes ilm phase change propagation on patterns.\r\n- Adds missing tests for useResultsRollup functionality\r\n\r\n## UI changes\r\n\r\n### Before\r\n\r\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\r\n\r\n### After\r\n\r\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4","sha":"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/198806","number":198806,"state":"MERGED","mergeCommit":{"sha":"fa0bddaac166c1bd17989a54b183677203f1812b","message":"[8.x] [Security Solution][Data Quality Dashboard] fix pattern state reset on ilm phase filter change (#198549) (#198806)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Security Solution][Data Quality Dashboard] fix pattern state reset\non ilm phase filter change\n(#198549)](https://github.com/elastic/kibana/pull/198549)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Karen\nGrigoryan\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-11-04T15:09:12Z\",\"message\":\"[Security\nSolution][Data Quality Dashboard] fix pattern state reset on ilm phase\nfilter change (#198549)\\n\\naddresses #196523\\r\\n\\r\\n- Fixes ilm phase\nchange propagation on patterns.\\r\\n- Adds missing tests for\nuseResultsRollup functionality\\r\\n\\r\\n## UI changes\\r\\n\\r\\n###\nBefore\\r\\n\\r\\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\\r\\n\\r\\n###\nAfter\\r\\n\\r\\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4\",\"sha\":\"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:Threat\nHunting\",\"Team:Threat\nHunting:Explore\",\"backport:prev-minor\",\"ci:cloud-deploy\",\"ci:project-deploy-security\"],\"title\":\"[Security\nSolution][Data Quality Dashboard] fix pattern state reset on ilm phase\nfilter\nchange\",\"number\":198549,\"url\":\"https://github.com/elastic/kibana/pull/198549\",\"mergeCommit\":{\"message\":\"[Security\nSolution][Data Quality Dashboard] fix pattern state reset on ilm phase\nfilter change (#198549)\\n\\naddresses #196523\\r\\n\\r\\n- Fixes ilm phase\nchange propagation on patterns.\\r\\n- Adds missing tests for\nuseResultsRollup functionality\\r\\n\\r\\n## UI changes\\r\\n\\r\\n###\nBefore\\r\\n\\r\\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\\r\\n\\r\\n###\nAfter\\r\\n\\r\\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4\",\"sha\":\"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/198549\",\"number\":198549,\"mergeCommit\":{\"message\":\"[Security\nSolution][Data Quality Dashboard] fix pattern state reset on ilm phase\nfilter change (#198549)\\n\\naddresses #196523\\r\\n\\r\\n- Fixes ilm phase\nchange propagation on patterns.\\r\\n- Adds missing tests for\nuseResultsRollup functionality\\r\\n\\r\\n## UI changes\\r\\n\\r\\n###\nBefore\\r\\n\\r\\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\\r\\n\\r\\n###\nAfter\\r\\n\\r\\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4\",\"sha\":\"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Karen Grigoryan <[email protected]>"}}]}] BACKPORT-->
kapral18
changed the title
[Security Solution][Data Quality Dashboard] Check state reset on ilm phase change
[Security Solution][Data Quality Dashboard][ESS] Check state reset on ilm phase change
Nov 20, 2024
Issue validated and fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Data Health Quality
Data health quality dashboard and related features
fixed
Team:Threat Hunting:Explore
Team:Threat Hunting
Security Solution Threat Hunting Team
v8.16.1
v8.17.0
v9.0.0
Describe the bug:
If ILM phase filter is changed, even if it's unrelated to phases of indices represented
it causes reset of UI check state presentation as if no checks are present or checks are gone.
Kibana/Elasticsearch Stack version: all supported versions
Steps to reproduce:
Current behavior:
Pattern list check states are full reset
Expected behavior:
Pattern list should maintain check states across phase filter changes only filtering out
indices with unselected phases
Screenshots (if relevant):
https://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017
The text was updated successfully, but these errors were encountered: