Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor deprecated ES API usage #196491

Closed
kertal opened this issue Oct 16, 2024 · 1 comment · Fixed by #202735
Closed

Refactor deprecated ES API usage #196491

kertal opened this issue Oct 16, 2024 · 1 comment · Fixed by #202735
Assignees
@lukasolson
Labels
chore impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture v9.0.0

Comments

@kertal
Copy link
Member

kertal commented Oct 16, 2024 •
edited
Loading

For 9.0 readyness we need to make sure to take care of removing deprecated ES API usage, that's exclusively is being consumed in our tests.

The most recent list can be found on https://github.com/elastic/kibana-team/issues/1173, it changes over time.
@kertal kertal added chore release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v9.0.0 labels Oct 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. technical debt Improvement of the software architecture and operational architecture labels Oct 16, 2024
@lukasolson lukasolson mentioned this issue Dec 3, 2024
Merged
1 task
lukasolson added a commit that referenced this issue Dec 11, 2024
@lukasolson
Add limit to Discover ES|QL queries to remove deprecation warnings (#…
162b149 
…202735)

## Summary

Resolves #196491.

Adds a `LIMIT` to our ES|QL Discover tests. Without the `LIMIT` we are
getting the following deprecation messages:

> Elasticsearch deprecation: 299
Elasticsearch-9.0.0-c74c06daee0583562c82597b19178268b9f415e5 "No limit
defined, adding default limit of [1000]"

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 11, 2024
@lukasolson
Add limit to Discover ES|QL queries to remove deprecation warnings (e…
675b276 
…lastic#202735)

## Summary

Resolves elastic#196491.

Adds a `LIMIT` to our ES|QL Discover tests. Without the `LIMIT` we are
getting the following deprecation messages:

> Elasticsearch deprecation: 299
Elasticsearch-9.0.0-c74c06daee0583562c82597b19178268b9f415e5 "No limit
defined, adding default limit of [1000]"

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 162b149)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@lukasolson @CAWilson94
Add limit to Discover ES|QL queries to remove deprecation warnings (e…
dd1ef40 
…lastic#202735)

## Summary

Resolves elastic#196491.

Adds a `LIMIT` to our ES|QL Discover tests. Without the `LIMIT` we are
getting the following deprecation messages:

> Elasticsearch deprecation: 299
Elasticsearch-9.0.0-c74c06daee0583562c82597b19178268b9f415e5 "No limit
defined, adding default limit of [1000]"

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
@lukasolson @CAWilson94
Add limit to Discover ES|QL queries to remove deprecation warnings (e…
36264ae 
…lastic#202735)

## Summary

Resolves elastic#196491.

Adds a `LIMIT` to our ES|QL Discover tests. Without the `LIMIT` we are
getting the following deprecation messages:

> Elasticsearch deprecation: 299
Elasticsearch-9.0.0-c74c06daee0583562c82597b19178268b9f415e5 "No limit
defined, adding default limit of [1000]"

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukasolson lukasolson

Labels
chore impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add limit to Discover ES|QL queries to remove deprecation warnings lukasolson/kibana
3 participants
@kertal @lukasolson @elasticmachine