Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ItemBuffer to package #196455

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

lukasolson
Copy link
Member

Summary

Part of #186139.

Bfetch exports ItemBuffer and TimedItemBuffer, the latter of which is also used inside of the content management plugin.

After bfetch is removed, content management will be the sole consumer, which is why I've added the team ownership to be appex-sharedux.

Checklist

@lukasolson lukasolson added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Oct 15, 2024
@lukasolson lukasolson self-assigned this Oct 15, 2024
@lukasolson lukasolson force-pushed the remove_bfetch_item_buffer branch from 59a2818 to 545605b Compare October 16, 2024 17:10
@lukasolson lukasolson marked this pull request as ready for review October 17, 2024 18:37
@lukasolson lukasolson requested a review from a team as a code owner October 17, 2024 18:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
bfetch 25 27 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/item-buffer - 14 +14
bfetch 73 59 -14
total -0
Unknown metric groups

API count

id before after diff
@kbn/item-buffer - 23 +23
bfetch 83 60 -23
total -0

History

cc @lukasolson

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Oct 18, 2024
@lukasolson lukasolson merged commit b0bae06 into elastic:main Oct 18, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants