Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automatic Import] Fixing only show cel generation flow when user selects cel input #196356

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

kgeller
Copy link
Contributor

@kgeller kgeller commented Oct 15, 2024

Summary

Fixing the Automatic Import flow so that cel generation only occurs when user selects the CEL input in the dropdown.

@kgeller kgeller added bug Fixes for quality problems that affect the customer experience backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:Security-Scalability Team label for Security Integrations Scalability Team Feature:AutomaticImport labels Oct 15, 2024
@kgeller kgeller self-assigned this Oct 15, 2024
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgeller kgeller marked this pull request as ready for review October 15, 2024 17:56
@kgeller kgeller requested a review from a team as a code owner October 15, 2024 17:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-scalability (Team:Security-Scalability)

@kgeller kgeller added the release_note:skip Skip the PR/issue when compiling release notes label Oct 15, 2024
@kgeller kgeller enabled auto-merge (squash) October 15, 2024 19:31
@kgeller kgeller merged commit cb30988 into elastic:main Oct 15, 2024
20 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11355073850

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
integrationAssistant 878.1KB 878.4KB +277.0B

History

cc @kgeller

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 15, 2024
…ects cel input (elastic#196356)

## Summary

Fixing the Automatic Import flow so that cel generation only occurs when
user selects the CEL input in the dropdown.

(cherry picked from commit cb30988)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 15, 2024
…er selects cel input (#196356) (#196450)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Automatic Import] Fixing only show cel generation flow when user
selects cel input
(#196356)](#196356)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kylie
Meli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T22:03:42Z","message":"[Automatic
Import] Fixing only show cel generation flow when user selects cel input
(#196356)\n\n## Summary\r\n\r\nFixing the Automatic Import flow so that
cel generation only occurs when\r\nuser selects the CEL input in the
dropdown.","sha":"cb309882166172fa59aac0d0e839edcd1ae43c61","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","backport:prev-minor","Team:Security-Scalability","Feature:AutomaticImport"],"title":"[Automatic
Import] Fixing only show cel generation flow when user selects cel
input","number":196356,"url":"https://github.com/elastic/kibana/pull/196356","mergeCommit":{"message":"[Automatic
Import] Fixing only show cel generation flow when user selects cel input
(#196356)\n\n## Summary\r\n\r\nFixing the Automatic Import flow so that
cel generation only occurs when\r\nuser selects the CEL input in the
dropdown.","sha":"cb309882166172fa59aac0d0e839edcd1ae43c61"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196356","number":196356,"mergeCommit":{"message":"[Automatic
Import] Fixing only show cel generation flow when user selects cel input
(#196356)\n\n## Summary\r\n\r\nFixing the Automatic Import flow so that
cel generation only occurs when\r\nuser selects the CEL input in the
dropdown.","sha":"cb309882166172fa59aac0d0e839edcd1ae43c61"}}]}]
BACKPORT-->

Co-authored-by: Kylie Meli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience Feature:AutomaticImport release_note:skip Skip the PR/issue when compiling release notes Team:Security-Scalability Team label for Security Integrations Scalability Team v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants