Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kibana Connectors] Inference Connector extend tests coverage. #196032

Open
Tracked by #188043
YulNaumenko opened this issue Oct 13, 2024 · 0 comments
Open
Tracked by #188043

[Kibana Connectors] Inference Connector extend tests coverage. #196032

YulNaumenko opened this issue Oct 13, 2024 · 0 comments
Labels
Team:Integrations Team Label for Observability Integrations team

Comments

@YulNaumenko
Copy link
Contributor

YulNaumenko commented Oct 13, 2024

For some of our simulators, we create a single simulator, and determine how to react based on the request coming in. Maybe a field is set to returnError or such, then it returns error instead of the response. May not work for this case, but thought I'd mention it.

Add more test coverage according to the comments below:

These tests should be also checking if the interference did or did not get created, right? And also testing some error conditions, I guess like the case where the same infererence would be created, and so the pre-save hook fails?

Seems like we will also want some delete tests, checking to make sure the inference gets deleted. Maybe one where the inference is ALREADY deleted, but not the connector. What happens then?

The comments here are mostly nits. I think we are REALLY going to want a function test where we update the config and secrets properties spec'd as objects with any allowed keys. We want to create the connector, update those properties such that we remove a property already there, and add one that's not there, to both config and secrets. Then do a GET and make sure we can still read the connector, and that it has the expected values. Then execute the connector - we want to make sure the secrets can still be decrypted - the connector will fail early if that's the case, and won't even call the connectors executor function.

@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 13, 2024
@dej611 dej611 added the Team:Integrations Team Label for Observability Integrations team label Oct 17, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Integrations Team Label for Observability Integrations team
Projects
None yet
Development

No branches or pull requests

2 participants