You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For some of our simulators, we create a single simulator, and determine how to react based on the request coming in. Maybe a field is set to returnError or such, then it returns error instead of the response. May not work for this case, but thought I'd mention it.
Add more test coverage according to the comments below:
These tests should be also checking if the interference did or did not get created, right? And also testing some error conditions, I guess like the case where the same infererence would be created, and so the pre-save hook fails?
Seems like we will also want some delete tests, checking to make sure the inference gets deleted. Maybe one where the inference is ALREADY deleted, but not the connector. What happens then?
The comments here are mostly nits. I think we are REALLY going to want a function test where we update the config and secrets properties spec'd as objects with any allowed keys. We want to create the connector, update those properties such that we remove a property already there, and add one that's not there, to both config and secrets. Then do a GET and make sure we can still read the connector, and that it has the expected values. Then execute the connector - we want to make sure the secrets can still be decrypted - the connector will fail early if that's the case, and won't even call the connectors executor function.
The text was updated successfully, but these errors were encountered:
For some of our simulators, we create a single simulator, and determine how to react based on the request coming in. Maybe a field is set to returnError or such, then it returns error instead of the response. May not work for this case, but thought I'd mention it.
Add more test coverage according to the comments below:
The text was updated successfully, but these errors were encountered: