[Cloud Security] Handle critical errors returned from the Agentless API when creating and deleting agentless agents #195997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanrathier
force-pushed
the
10657-agentless-handle-critical-error-statuses
branch
from
ed2b902 to
917cec7
Compare
seanrathier
added
8.17 candidate
backport:prev-minor
seanrathier
changed the title
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
seanrathier
force-pushed
the
10657-agentless-handle-critical-error-statuses
branch
from
869782e to
d8ddf42
Compare
maxcold
approved these changes
Oct 23, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @seanrathier |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 23, 2024
…PI when creating and deleting agentless agents (elastic#195997) (cherry picked from commit d153584)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 23, 2024
…less API when creating and deleting agentless agents (#195997) (#197490) # Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] Handle critical errors returned from the Agentless API when creating and deleting agentless agents (#195997)](#195997) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"seanrathier","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-23T15:46:26Z","message":"[Cloud Security] Handle critical errors returned from the Agentless API when creating and deleting agentless agents (#195997)","sha":"d15358496b8cbc153d494f9a8f70c9400ebb1d66","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Cloud Security","backport:prev-minor","ci:project-deploy-security","8.17 candidate"],"title":"[Cloud Security] Handle critical errors returned from the Agentless API when creating and deleting agentless agents","number":195997,"url":"https://github.com/elastic/kibana/pull/195997","mergeCommit":{"message":"[Cloud Security] Handle critical errors returned from the Agentless API when creating and deleting agentless agents (#195997)","sha":"d15358496b8cbc153d494f9a8f70c9400ebb1d66"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195997","number":195997,"mergeCommit":{"message":"[Cloud Security] Handle critical errors returned from the Agentless API when creating and deleting agentless agents (#195997)","sha":"d15358496b8cbc153d494f9a8f70c9400ebb1d66"}}]}] BACKPORT--> Co-authored-by: seanrathier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are adding more defined error handling on the statuses returned from the Agentless API. This includes some changes to the data and messages being logged and the error that is thrown to the user.
We've also refactored the code to have the agentless agent
createanddeleteactions share the same handling function.Checklist
Delete any items that are not applicable to this PR.