-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search: Indices page] Unavailable button is being announced together with Default settings dialog information #195951
Labels
defect-level-3
Moderate UX disruption or potentially confusing
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
Project:Accessibility
Team:Search
WCAG A
Comments
L1nBra
added
WCAG A
Team:Search
defect-level-3
Moderate UX disruption or potentially confusing
labels
Oct 11, 2024
L1nBra
added
the
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
label
Oct 17, 2024
@DianaJourdan I've added this to the Extract & Transform team project |
L1nBra
changed the title
[Stateful: Indices page] Unavailable button is being announced together with Default settings dialog information
[Search: Indices page] Unavailable button is being announced together with Default settings dialog information
Nov 7, 2024
JoseLuisGJ
added a commit
that referenced
this issue
Nov 22, 2024
…efault Settings (#201163) ## Summary This PR solves the issues #195951 and #195942 getting the focus on the first interactive element as suggested which is the _ingest pipelines_ external link after pressing enter using the keyboard navigation either the _Reset_ or _Save_ buttons. With this the screen reader announces the _ingest pipelines_ content after any of those previous events. ![CleanShot 2024-11-22 at 10 16 08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 22, 2024
…efault Settings (elastic#201163) ## Summary This PR solves the issues elastic#195951 and elastic#195942 getting the focus on the first interactive element as suggested which is the _ingest pipelines_ external link after pressing enter using the keyboard navigation either the _Reset_ or _Save_ buttons. With this the screen reader announces the _ingest pipelines_ content after any of those previous events. ![CleanShot 2024-11-22 at 10 16 08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac) (cherry picked from commit 56ee089)
kibanamachine
added a commit
that referenced
this issue
Nov 22, 2024
…Save Default Settings (#201163) (#201404) # Backport This will backport the following commits from `main` to `8.x`: - [[Search][a11y] Fixing wrong navigation sequence after Reset or Save Default Settings (#201163)](#201163) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"José Luis González","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T14:42:16Z","message":"[Search][a11y] Fixing wrong navigation sequence after Reset or Save Default Settings (#201163)\n\n## Summary\r\n\r\nThis PR solves the issues\r\nhttps://github.com//issues/195951 and\r\nhttps://github.com//issues/195942 getting the focus on the\r\nfirst interactive element as suggested which is the _ingest pipelines_\r\nexternal link after pressing enter using the keyboard navigation either\r\nthe _Reset_ or _Save_ buttons. With this the screen reader announces the\r\n_ingest pipelines_ content after any of those previous events.\r\n\r\n![CleanShot 2024-11-22 at 10 16\r\n08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac)","sha":"56ee08946c1bead9d44829a9adfb11700522e70f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","accessibility: keyboard navigation","backport:prev-minor"],"title":"[Search][a11y] Fixing wrong navigation sequence after Reset or Save Default Settings","number":201163,"url":"https://github.com/elastic/kibana/pull/201163","mergeCommit":{"message":"[Search][a11y] Fixing wrong navigation sequence after Reset or Save Default Settings (#201163)\n\n## Summary\r\n\r\nThis PR solves the issues\r\nhttps://github.com//issues/195951 and\r\nhttps://github.com//issues/195942 getting the focus on the\r\nfirst interactive element as suggested which is the _ingest pipelines_\r\nexternal link after pressing enter using the keyboard navigation either\r\nthe _Reset_ or _Save_ buttons. With this the screen reader announces the\r\n_ingest pipelines_ content after any of those previous events.\r\n\r\n![CleanShot 2024-11-22 at 10 16\r\n08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac)","sha":"56ee08946c1bead9d44829a9adfb11700522e70f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201163","number":201163,"mergeCommit":{"message":"[Search][a11y] Fixing wrong navigation sequence after Reset or Save Default Settings (#201163)\n\n## Summary\r\n\r\nThis PR solves the issues\r\nhttps://github.com//issues/195951 and\r\nhttps://github.com//issues/195942 getting the focus on the\r\nfirst interactive element as suggested which is the _ingest pipelines_\r\nexternal link after pressing enter using the keyboard navigation either\r\nthe _Reset_ or _Save_ buttons. With this the screen reader announces the\r\n_ingest pipelines_ content after any of those previous events.\r\n\r\n![CleanShot 2024-11-22 at 10 16\r\n08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac)","sha":"56ee08946c1bead9d44829a9adfb11700522e70f"}}]}] BACKPORT--> Co-authored-by: José Luis González <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this issue
Nov 26, 2024
…efault Settings (elastic#201163) ## Summary This PR solves the issues elastic#195951 and elastic#195942 getting the focus on the first interactive element as suggested which is the _ingest pipelines_ external link after pressing enter using the keyboard navigation either the _Reset_ or _Save_ buttons. With this the screen reader announces the _ingest pipelines_ content after any of those previous events. ![CleanShot 2024-11-22 at 10 16 08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac)
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Dec 12, 2024
…efault Settings (elastic#201163) ## Summary This PR solves the issues elastic#195951 and elastic#195942 getting the focus on the first interactive element as suggested which is the _ingest pipelines_ external link after pressing enter using the keyboard navigation either the _Reset_ or _Save_ buttons. With this the screen reader announces the _ingest pipelines_ content after any of those previous events. ![CleanShot 2024-11-22 at 10 16 08](https://github.com/user-attachments/assets/ca8d5739-fcea-42da-af14-031989a84bac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
defect-level-3
Moderate UX disruption or potentially confusing
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
Project:Accessibility
Team:Search
WCAG A
Description
Reset button, which becomes inactive after clicking it, is not accessible with the mouse nor keyboard, which is correct, but screen reader announces the button as unavailable when user reaches again Default settings and hears dialog information.
Preconditions
Stateful Indices page is opened.
At least one index is added.
Use Screen Reader (NVDA).
Steps to reproduce
1.Navigate to Default settings button while using only keyboard by pressing Tab key.
2.Press Enter.
3.Navigate to any switch button inside the dialog window (f.e.: Content extraction switch).
4.Press Enter key on switch button
5.Navigate to Reset button while pressing Tab key.
6.Press Enter.
7.Press Tab key.
8.Observe Screen Reader announcement.
UI elements
NVDA Speech Viewer
Actual Result
Same behavior after pressing Enter key on Save button and then Tab key.
Expected Result
Meta Issue
Kibana Version: 8.16.0-SNAPSHOT
OS: Windows 11 Pro
Browser: Chrome Version 129.0.6668.70 (Official Build) (64-bit)
Screen reader: NVDA
WCAG or Vendor Guidance (optional)
Related to: https://github.com/elastic/search-team/issues/8256
The text was updated successfully, but these errors were encountered: