[Monitoring] Improved "Nodes changed" rule alert message #195699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consulthys
added
Team:Monitoring
maramos-elastic
approved these changes
Oct 10, 2024
💚 Build Succeeded
Metrics [docs]
History
cc @consulthys |
consulthys
added
backport
and removed
backport:skip
consulthys
added
v8.15.3
v8.16.0
and removed
backport:skip
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
consulthys
added
backport:version
|
Starting backport for target branches: 8.16 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2024
) Closes elastic#195533 ## Summary This PR fixes the format of the message of the Stack Monitoring built-in "Nodes changed" alert to be less confusing. The message now lists the added/removed/restarted nodes in a clearer fashion. Instead of ``` Nodes changed alert is firing for cluster-name-xyz (abc123). The following Elasticsearch nodes have been added: removed: instance-0000000012 restarted. ``` The message now shows like ``` Nodes changed alert is firing for cluster-name-xyz (abc123). The following Elasticsearch nodes have been added: none / removed: instance-0000000012 / restarted: none ``` ### Checklist - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [X] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit 819d80a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
|
@consulthys there's a version gap with this backport. Can you check if this should also be backported to 8.x/8.17? |
|
@jbudz Sorry, my bad, 8.17 is totally fine |
consulthys
removed
the
backport missing
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Oct 21, 2024
…sage (#195699) (#196630) # Backport This will backport the following commits from `main` to `8.16`: - [[Monitoring] Improved "Nodes changed" rule alert message (#195699)](#195699) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Valentin Crettaz","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-11T14:06:45Z","message":"[Monitoring] Improved \"Nodes changed\" rule alert message (#195699)\n\nCloses https://github.com/elastic/kibana/issues/195533\r\n\r\n## Summary\r\n\r\nThis PR fixes the format of the message of the Stack Monitoring built-in\r\n\"Nodes changed\" alert to be less confusing.\r\n\r\nThe message now lists the added/removed/restarted nodes in a clearer\r\nfashion.\r\n\r\nInstead of\r\n```\r\nNodes changed alert is firing for cluster-name-xyz (abc123). The following Elasticsearch nodes have been added: removed: instance-0000000012 restarted.\r\n```\r\nThe message now shows like\r\n```\r\nNodes changed alert is firing for cluster-name-xyz (abc123). The following Elasticsearch nodes have been added: none / removed: instance-0000000012 / restarted: none\r\n```\r\n\r\n### Checklist\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [X] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [X] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"819d80a649dbcc6d7faf88f92b1f58039002ebe1","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","Team:Monitoring","release_note:skip","Feature:Stack Monitoring","v9.0.0","v8.16.0","backport:version"],"title":"[Monitoring] Improved \"Nodes changed\" rule alert message","number":195699,"url":"https://github.com/elastic/kibana/pull/195699","mergeCommit":{"message":"[Monitoring] Improved \"Nodes changed\" rule alert message (#195699)\n\nCloses https://github.com/elastic/kibana/issues/195533\r\n\r\n## Summary\r\n\r\nThis PR fixes the format of the message of the Stack Monitoring built-in\r\n\"Nodes changed\" alert to be less confusing.\r\n\r\nThe message now lists the added/removed/restarted nodes in a clearer\r\nfashion.\r\n\r\nInstead of\r\n```\r\nNodes changed alert is firing for cluster-name-xyz (abc123). The following Elasticsearch nodes have been added: removed: instance-0000000012 restarted.\r\n```\r\nThe message now shows like\r\n```\r\nNodes changed alert is firing for cluster-name-xyz (abc123). The following Elasticsearch nodes have been added: none / removed: instance-0000000012 / restarted: none\r\n```\r\n\r\n### Checklist\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [X] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [X] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"819d80a649dbcc6d7faf88f92b1f58039002ebe1"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195699","number":195699,"mergeCommit":{"message":"[Monitoring] Improved \"Nodes changed\" rule alert message (#195699)\n\nCloses https://github.com/elastic/kibana/issues/195533\r\n\r\n## Summary\r\n\r\nThis PR fixes the format of the message of the Stack Monitoring built-in\r\n\"Nodes changed\" alert to be less confusing.\r\n\r\nThe message now lists the added/removed/restarted nodes in a clearer\r\nfashion.\r\n\r\nInstead of\r\n```\r\nNodes changed alert is firing for cluster-name-xyz (abc123). The following Elasticsearch nodes have been added: removed: instance-0000000012 restarted.\r\n```\r\nThe message now shows like\r\n```\r\nNodes changed alert is firing for cluster-name-xyz (abc123). The following Elasticsearch nodes have been added: none / removed: instance-0000000012 / restarted: none\r\n```\r\n\r\n### Checklist\r\n\r\n- [X] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [X] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [X] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [X] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"819d80a649dbcc6d7faf88f92b1f58039002ebe1"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Valentin Crettaz <[email protected]>
kibanamachine
added
v8.16.0
and removed
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #195533
Summary
This PR fixes the format of the message of the Stack Monitoring built-in "Nodes changed" alert to be less confusing.
The message now lists the added/removed/restarted nodes in a clearer fashion.
Instead of
The message now shows like
Checklist