Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Connectors] add additional function tests for pre/post save/delete hooks #195663

Open
pmuellr opened this issue Oct 9, 2024 · 1 comment
Labels
Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture

Comments

@pmuellr
Copy link
Member

pmuellr commented Oct 9, 2024

In PR add pre-create, pre-update, and post-delete hooks for connectors #194081, we added jests that test for hook failures and saved object operation failures. But we only have "happy path" function tests for these cases. We should add some function tests for these, similar to the jest ones - test for hooks throwing errors and for the SO operations to fail.

Not sure if we can force an SO operation to fail in this case, from FTR - if not, we certainly can in a jest integration test, and it would be fine to add the tests that way ...

@pmuellr pmuellr added Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Oct 9, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@mikecote mikecote added the technical debt Improvement of the software architecture and operational architecture label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

3 participants