Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] surface styling meta request failures as warning #195294

Closed
nreese opened this issue Oct 7, 2024 · 1 comment · Fixed by #200860
Closed

[maps] surface styling meta request failures as warning #195294

nreese opened this issue Oct 7, 2024 · 1 comment · Fixed by #200860
Assignees
@kowalczyk-krzysztof
Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps good first issue low hanging fruit Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Oct 7, 2024

Steps

  1. install sample web logs
  2. Create run time field named [bytes], typed as double, with value emit(doc['bytes'].value),
  3. create map with documents layer and style markers by [bytes]. Notice how the markers are not styled an no information is provided to the user about the problem
    Image
  4. Using kibana inspector, we can see that aggregation to fetch the min and max value failed. This message should be surfaced to the user as a warning in the legend.
    Image
@nreese nreese added bug Fixes for quality problems that affect the customer experience Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Oct 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added the good first issue low hanging fruit label Oct 23, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Nov 18, 2024
@kowalczyk-krzysztof kowalczyk-krzysztof mentioned this issue Nov 20, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 26, 2024
@kowalczyk-krzysztof
[Maps] Surface data request errors (elastic#200860)
073fc15 
## Summary

This PR makes it to so data request errors are surfaced to users, as a
warning.

Closes: elastic#195294
(cherry picked from commit 1f57890)
kibanamachine added a commit that referenced this issue Nov 26, 2024
@kibanamachine @kowalczyk-krzysztof
[8.x] [Maps] Surface data request errors (#200860) (#201743)
232515e 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Maps] Surface data request errors
(#200860)](#200860)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Krzysztof
Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T10:18:45Z","message":"[Maps]
Surface data request errors (#200860)\n\n## Summary\r\n\r\nThis PR makes
it to so data request errors are surfaced to users, as
a\r\nwarning.\r\n\r\nCloses:
#195294","sha":"1f578909832a9e00342c33fee03f9bd79b5f28b1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Team:Presentation","release_note:skip","v9.0.0","backport:prev-minor","Feature:Maps"],"title":"[Maps]
Surface data request
errors","number":200860,"url":"https://github.com/elastic/kibana/pull/200860","mergeCommit":{"message":"[Maps]
Surface data request errors (#200860)\n\n## Summary\r\n\r\nThis PR makes
it to so data request errors are surfaced to users, as
a\r\nwarning.\r\n\r\nCloses:
#195294","sha":"1f578909832a9e00342c33fee03f9bd79b5f28b1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200860","number":200860,"mergeCommit":{"message":"[Maps]
Surface data request errors (#200860)\n\n## Summary\r\n\r\nThis PR makes
it to so data request errors are surfaced to users, as
a\r\nwarning.\r\n\r\nCloses:
#195294","sha":"1f578909832a9e00342c33fee03f9bd79b5f28b1"}}]}]
BACKPORT-->

Co-authored-by: Krzysztof Kowalczyk <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this issue Nov 26, 2024
@kowalczyk-krzysztof @paulinashakirova
[Maps] Surface data request errors (elastic#200860)
0fde56c 
## Summary

This PR makes it to so data request errors are surfaced to users, as a
warning.

Closes: elastic#195294
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@kowalczyk-krzysztof @CAWilson94
[Maps] Surface data request errors (elastic#200860)
95d39b2 
## Summary

This PR makes it to so data request errors are surfaced to users, as a
warning.

Closes: elastic#195294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kowalczyk-krzysztof kowalczyk-krzysztof

Labels
bug Fixes for quality problems that affect the customer experience Feature:Maps good first issue low hanging fruit Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Maps] Surface data request errors kowalczyk-krzysztof/kibana
3 participants
@nreese @elasticmachine @kowalczyk-krzysztof