Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Rules] Use the new rule form to the create rules flyout #195211

Open
1 of 4 tasks
cnasikas opened this issue Oct 7, 2024 · 3 comments
Open
1 of 4 tasks

[ResponseOps][Rules] Use the new rule form to the create rules flyout #195211

cnasikas opened this issue Oct 7, 2024 · 3 comments
Assignees
@Zacqary
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@cnasikas
Copy link
Member

cnasikas commented Oct 7, 2024 •
edited
Loading

In #175634 we implemented the new rule form. We should use the new rule form on the create rules flyout.

Related: #179108

Designs: https://www.figma.com/design/zetHXnUP0YnDG4YmvPwRb8/Adapt-new-Rule-form-to-work-in-flyout?node-id=1-191&node-type=canvas&t=PyPLu7smPOf1cqj9-0

DoD
Preview Give feedback
@cnasikas cnasikas added Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Oct 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@cnasikas cnasikas mentioned this issue Oct 16, 2024
Open
@Zacqary
Copy link
Contributor

Zacqary commented Oct 24, 2024

Working on new package task in an initial PR

Lots of code to move and reroute, might be a big job

@cnasikas
Copy link
Member Author

Thanks @Zacqary! No worries. Plz move code relevant to the form. Any types,hooks, etc that are being used either by the @kbn/alerts-ui-shared or triggers_actions_ui or any solution should remain in @kbn/alerts-ui-shared and the new package can import from the @kbn/alerts-ui-shared whatever it needs.

@cnasikas cnasikas mentioned this issue Nov 1, 2024
Closed
@Zacqary Zacqary mentioned this issue Nov 1, 2024
Merged
1 task
Zacqary added a commit that referenced this issue Dec 3, 2024
@Zacqary @kibanamachine @kdelemme
[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-…
8f267fd 
…form (#198725)

## Summary

Part of #195211

Moves Rule Form code out of `@kbn/alerts-ui-shared` and into a new
package called `@kbn/response-ops-rule-form`.

Some types and hooks that are used by multiple features or solutions are
still in `@kbn/alerts-ui-shared` and have been rerouted. The bulk of
Rule Form-specific code is in this new package.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Kevin Delemme <[email protected]>
cnasikas added a commit that referenced this issue Dec 4, 2024
@Zacqary @cnasikas
[8.x] [ResponseOps][Rules] Move Rule Form code into @kbn/response-ops…
4beeb72 
…-rule-form (#198725) (#202907)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Rules] Move Rule Form code into
@kbn/response-ops-rule-form
(#198725)](#198725)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Zacqary Adam
Xeper","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-03T18:40:48Z","message":"[ResponseOps][Rules]
Move Rule Form code into @kbn/response-ops-rule-form (#198725)\n\n##
Summary\r\n\r\nPart of #195211\r\n\r\nMoves Rule Form code out of
`@kbn/alerts-ui-shared` and into a new\r\npackage called
`@kbn/response-ops-rule-form`.\r\n\r\nSome types and hooks that are used
by multiple features or solutions are\r\nstill in
`@kbn/alerts-ui-shared` and have been rerouted. The bulk of\r\nRule
Form-specific code is in this new package.\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Kevin Delemme
<[email protected]>","sha":"8f267fd83c05c3c7c97a07e7abb671c35fc7a617","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Team:Fleet","v9.0.0","Feature:Alerting/RulesManagement","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.18.0"],"number":198725,"url":"https://github.com/elastic/kibana/pull/198725","mergeCommit":{"message":"[ResponseOps][Rules]
Move Rule Form code into @kbn/response-ops-rule-form (#198725)\n\n##
Summary\r\n\r\nPart of #195211\r\n\r\nMoves Rule Form code out of
`@kbn/alerts-ui-shared` and into a new\r\npackage called
`@kbn/response-ops-rule-form`.\r\n\r\nSome types and hooks that are used
by multiple features or solutions are\r\nstill in
`@kbn/alerts-ui-shared` and have been rerouted. The bulk of\r\nRule
Form-specific code is in this new package.\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Kevin Delemme
<[email protected]>","sha":"8f267fd83c05c3c7c97a07e7abb671c35fc7a617"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198725","number":198725,"mergeCommit":{"message":"[ResponseOps][Rules]
Move Rule Form code into @kbn/response-ops-rule-form (#198725)\n\n##
Summary\r\n\r\nPart of #195211\r\n\r\nMoves Rule Form code out of
`@kbn/alerts-ui-shared` and into a new\r\npackage called
`@kbn/response-ops-rule-form`.\r\n\r\nSome types and hooks that are used
by multiple features or solutions are\r\nstill in
`@kbn/alerts-ui-shared` and have been rerouted. The bulk of\r\nRule
Form-specific code is in this new package.\r\n\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Kevin Delemme
<[email protected]>","sha":"8f267fd83c05c3c7c97a07e7abb671c35fc7a617"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Christos Nasikas <[email protected]>
hop-dev pushed a commit to hop-dev/kibana that referenced this issue Dec 5, 2024
@Zacqary @kibanamachine
@kdelemme @hop-dev
[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-…
1b41cca 
…form (elastic#198725)

## Summary

Part of elastic#195211

Moves Rule Form code out of `@kbn/alerts-ui-shared` and into a new
package called `@kbn/response-ops-rule-form`.

Some types and hooks that are used by multiple features or solutions are
still in `@kbn/alerts-ui-shared` and have been rerouted. The bulk of
Rule Form-specific code is in this new package.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Kevin Delemme <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 9, 2024
@Zacqary @kibanamachine
@kdelemme @CAWilson94
[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-…
a4519fc 
…form (elastic#198725)

## Summary

Part of elastic#195211

Moves Rule Form code out of `@kbn/alerts-ui-shared` and into a new
package called `@kbn/response-ops-rule-form`.

Some types and hooks that are used by multiple features or solutions are
still in `@kbn/alerts-ui-shared` and have been rerouted. The bulk of
Rule Form-specific code is in this new package.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Kevin Delemme <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@Zacqary @kibanamachine
@kdelemme @CAWilson94
[ResponseOps][Rules] Move Rule Form code into @kbn/response-ops-rule-…
7223ba5 
…form (elastic#198725)

## Summary

Part of elastic#195211

Moves Rule Form code out of `@kbn/alerts-ui-shared` and into a new
package called `@kbn/response-ops-rule-form`.

Some types and hooks that are used by multiple features or solutions are
still in `@kbn/alerts-ui-shared` and have been rerouted. The bulk of
Rule Form-specific code is in this new package.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Kevin Delemme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zacqary Zacqary

Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Zacqary @cnasikas @elasticmachine