[Reporting]: use outer layout dimension if exist when export to pdf

[linghaoSu]

Summary

Fixes #193748

When exporting to PDF, use the outer dimesion if it exists to avoid PDF stretching

20240929211620_rec_.mp4

[linghaoSu]

@elasticmachine merge upstream

[linghaoSu]

@elasticmachine merge upstream

[linghaoSu]

@elasticmachine merge upstream

[linghaoSu]

@elasticmachine merge upstream

[linghaoSu]

Hi @tsullivan,

I'm working on fixing the PDF export issue where it's not using the appropriate container width and height. I need the dimensions of the outerLayout, but I noticed in this commit you removed the layout definition:

https://github.com/elastic/kibana/pull/192530/files#diff-73b930fe3e0489c235ee39548ffb365bd9b32ee8e17d021bc702bc5d219ee5c3L50

However, I can still find it when running, and I need it to get the correct dimensions. I'd like to re-add it, but I'm not sure if this is the best approach to fix the issue.

Could you please provide some guidance?

[linghaoSu]

@elasticmachine merge upstream

[linghaoSu]

@elasticmachine merge upstream

[tsullivan]

Hi @tsullivan,

I'm working on fixing the PDF export issue where it's not using the appropriate container width and height. I need the dimensions of the outerLayout, but I noticed in this commit you removed the layout definition:

https://github.com/elastic/kibana/pull/192530/files#diff-73b930fe3e0489c235ee39548ffb365bd9b32ee8e17d021bc702bc5d219ee5c3L50

However, I can still find it when running, and I need it to get the correct dimensions. I'd like to re-add it, but I'm not sure if this is the best approach to fix the issue.

Could you please provide some guidance?

Hi @linghaoSu, sorry for my delay - I was on vacation.

The piece of code you link to is removing a layout field from the ReportingSharingData interface. That interface includes the information that is provided to the sharing modal from the app, and these things are known when the user first clicks the button to open the sharing modal. The layout information doesn't belong in that interface because it depends on the options that the user selects within the sharing modal.

The layout information belongs in the job parameters for reports that are requested. That is the BaseParams interface.

• BaseParams is defined here:

  kibana/packages/kbn-reporting/common/types.ts

  Line 64 in 7b9ff3d

  export interface BaseParams {

• The BaseParams object is created here:

  kibana/packages/kbn-reporting/public/share/share_context_menu/register_pdf_png_modal_reporting.tsx

  Line 114 in 7b9ff3d

  const decoratedJobParams = apiClient.getDecoratedJobParams({

Regarding the issue you are working on, it looks like a duplicate of #183550. @markov00 has done a really good investigation of the problem here: #183550 (comment)

[tsullivan]

Hi @linghaoSu, are there plans to keep working on this?

[linghaoSu]

Hi @linghaoSu, are there plans to keep working on this?

Sorry for the delay， I still have plans to solve this issue this week later.