Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controls] controls registry should store getFactory instead of factory to avoid importing async bundles on page load #194180

Closed
nreese opened this issue Sep 26, 2024 · 1 comment · Fixed by #194182
Closed

[controls] controls registry should store getFactory instead of factory to avoid importing async bundles on page load #194180

nreese opened this issue Sep 26, 2024 · 1 comment · Fixed by #194182
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Sep 26, 2024

Image
@nreese nreese added bug Fixes for quality problems that affect the customer experience project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Sep 26, 2024
@nreese nreese self-assigned this Sep 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese mentioned this issue Sep 26, 2024
Merged
@nreese nreese changed the title [controls] controls registry should store getFactory instead of factor to avoid importing async bundles on page load [controls] controls registry should store getFactory instead of factory to avoid importing async bundles on page load Sep 26, 2024
nreese added a commit that referenced this issue Sep 26, 2024
@nreese @kibanamachine @elasticmachine
[controls] fix controls plugin loading async chunks on home page (#19…
98b8df7 
…4182)

Closes #194180

PR resolves issue by updating registry to store getFactory instead of
the results of getFactory. In this way, `getFactory` is not executed
until control is rendered and bundle is needed.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 26, 2024
@nreese
[controls] fix controls plugin loading async chunks on home page (ela…
4475357 
…stic#194182)

Closes elastic#194180

PR resolves issue by updating registry to store getFactory instead of
the results of getFactory. In this way, `getFactory` is not executed
until control is rendered and bundle is needed.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 98b8df7)
kibanamachine referenced this issue Sep 26, 2024
@kibanamachine @nreese
[8.x] [controls] fix controls plugin loading async chunks on home page (
3f1ef96 
#194182) (#194235)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[controls] fix controls plugin loading async chunks on home page
(#194182)](#194182)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T22:12:38Z","message":"[controls]
fix controls plugin loading async chunks on home page
(#194182)\n\nCloses
https://github.com/elastic/kibana/issues/194180\r\n\r\nPR resolves issue
by updating registry to store getFactory instead of\r\nthe results of
getFactory. In this way, `getFactory` is not executed\r\nuntil control
is rendered and bundle is
needed.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"98b8df7253b8450b16e06c0355d67425fd772c3c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","v8.16.0","backport:version"],"title":"[controls]
fix controls plugin loading async chunks on home
page","number":194182,"url":"https://github.com/elastic/kibana/pull/194182","mergeCommit":{"message":"[controls]
fix controls plugin loading async chunks on home page
(#194182)\n\nCloses
https://github.com/elastic/kibana/issues/194180\r\n\r\nPR resolves issue
by updating registry to store getFactory instead of\r\nthe results of
getFactory. In this way, `getFactory` is not executed\r\nuntil control
is rendered and bundle is
needed.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"98b8df7253b8450b16e06c0355d67425fd772c3c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194182","number":194182,"mergeCommit":{"message":"[controls]
fix controls plugin loading async chunks on home page
(#194182)\n\nCloses
https://github.com/elastic/kibana/issues/194180\r\n\r\nPR resolves issue
by updating registry to store getFactory instead of\r\nthe results of
getFactory. In this way, `getFactory` is not executed\r\nuntil control
is rendered and bundle is
needed.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"98b8df7253b8450b16e06c0355d67425fd772c3c"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[controls] fix controls plugin loading async chunks on home page nreese/kibana
2 participants
@nreese @elasticmachine