Roles table does not sort #193786
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Users/Roles/API Keys
regression
Team:Security
Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Comments
kc13greiner
added
bug
|
Pinging @elastic/kibana-security (Team:Security) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Sep 27, 2024
…lastic#194196) Fixes elastic#193786 ## Summary Reverts a few changes made when the Roles grid page was moved to a functional component. Fixes regression in table sorting. ### Notes When preparing for the Query Roles API, we had moved the roles grid page to be a functional component. In doing so, we also migrated away from the In Memory table in favor of the basic table. EUIBasicTable does not support sorting out of the box and is meant to be used for server-side sorting, etc (unless we implement custom sorting logic). I've made a few changes: - Bring back the InMemoryTable but keep the Search Bar. - Remove few (now) unused functions which are to be brought back whenever the Query Roles API is ready. - Update tests ### Screen recording https://github.com/user-attachments/assets/4ac4f771-e7d1-4e17-807e-d6262767d100 ### Release notes Fixes UI regression in Roles listing page where users could not sort table by using the headers. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit f4ca9e4)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Sep 27, 2024
…lastic#194196) Fixes elastic#193786 ## Summary Reverts a few changes made when the Roles grid page was moved to a functional component. Fixes regression in table sorting. ### Notes When preparing for the Query Roles API, we had moved the roles grid page to be a functional component. In doing so, we also migrated away from the In Memory table in favor of the basic table. EUIBasicTable does not support sorting out of the box and is meant to be used for server-side sorting, etc (unless we implement custom sorting logic). I've made a few changes: - Bring back the InMemoryTable but keep the Search Bar. - Remove few (now) unused functions which are to be brought back whenever the Query Roles API is ready. - Update tests ### Screen recording https://github.com/user-attachments/assets/4ac4f771-e7d1-4e17-807e-d6262767d100 ### Release notes Fixes UI regression in Roles listing page where users could not sort table by using the headers. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit f4ca9e4)
kibanamachine
referenced
this issue
Sep 27, 2024
…header (#194196) (#194282) # Backport This will backport the following commits from `main` to `8.15`: - [[Roles] Fix bug with roles grid not sorting on clicking table header (#194196)](#194196) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sid","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-27T10:59:28Z","message":"[Roles] Fix bug with roles grid not sorting on clicking table header (#194196)\n\nFixes https://github.com/elastic/kibana/issues/193786\r\n\r\n## Summary\r\nReverts a few changes made when the Roles grid page was moved to a\r\nfunctional component. Fixes regression in table sorting.\r\n\r\n### Notes\r\n\r\nWhen preparing for the Query Roles API, we had moved the roles grid page\r\nto be a functional component. In doing so, we also migrated away from\r\nthe In Memory table in favor of the basic table. EUIBasicTable does not\r\nsupport sorting out of the box and is meant to be used for server-side\r\nsorting, etc (unless we implement custom sorting logic). I've made a few\r\nchanges:\r\n- Bring back the InMemoryTable but keep the Search Bar.\r\n- Remove few (now) unused functions which are to be brought back\r\nwhenever the Query Roles API is ready.\r\n- Update tests\r\n\r\n### Screen recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4ac4f771-e7d1-4e17-807e-d6262767d100\r\n\r\n\r\n\r\n### Release notes\r\nFixes UI regression in Roles listing page where users could not sort\r\ntable by using the headers.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f4ca9e4730ee6b13d19808be9fcc633dce9087d5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","regression","release_note:fix","Team:Security","Feature:Users/Roles/API Keys","v9.0.0","backport:prev-major"],"title":"[Roles] Fix bug with roles grid not sorting on clicking table header","number":194196,"url":"https://github.com/elastic/kibana/pull/194196","mergeCommit":{"message":"[Roles] Fix bug with roles grid not sorting on clicking table header (#194196)\n\nFixes https://github.com/elastic/kibana/issues/193786\r\n\r\n## Summary\r\nReverts a few changes made when the Roles grid page was moved to a\r\nfunctional component. Fixes regression in table sorting.\r\n\r\n### Notes\r\n\r\nWhen preparing for the Query Roles API, we had moved the roles grid page\r\nto be a functional component. In doing so, we also migrated away from\r\nthe In Memory table in favor of the basic table. EUIBasicTable does not\r\nsupport sorting out of the box and is meant to be used for server-side\r\nsorting, etc (unless we implement custom sorting logic). I've made a few\r\nchanges:\r\n- Bring back the InMemoryTable but keep the Search Bar.\r\n- Remove few (now) unused functions which are to be brought back\r\nwhenever the Query Roles API is ready.\r\n- Update tests\r\n\r\n### Screen recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4ac4f771-e7d1-4e17-807e-d6262767d100\r\n\r\n\r\n\r\n### Release notes\r\nFixes UI regression in Roles listing page where users could not sort\r\ntable by using the headers.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f4ca9e4730ee6b13d19808be9fcc633dce9087d5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194196","number":194196,"mergeCommit":{"message":"[Roles] Fix bug with roles grid not sorting on clicking table header (#194196)\n\nFixes https://github.com/elastic/kibana/issues/193786\r\n\r\n## Summary\r\nReverts a few changes made when the Roles grid page was moved to a\r\nfunctional component. Fixes regression in table sorting.\r\n\r\n### Notes\r\n\r\nWhen preparing for the Query Roles API, we had moved the roles grid page\r\nto be a functional component. In doing so, we also migrated away from\r\nthe In Memory table in favor of the basic table. EUIBasicTable does not\r\nsupport sorting out of the box and is meant to be used for server-side\r\nsorting, etc (unless we implement custom sorting logic). I've made a few\r\nchanges:\r\n- Bring back the InMemoryTable but keep the Search Bar.\r\n- Remove few (now) unused functions which are to be brought back\r\nwhenever the Query Roles API is ready.\r\n- Update tests\r\n\r\n### Screen recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4ac4f771-e7d1-4e17-807e-d6262767d100\r\n\r\n\r\n\r\n### Release notes\r\nFixes UI regression in Roles listing page where users could not sort\r\ntable by using the headers.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f4ca9e4730ee6b13d19808be9fcc633dce9087d5"}}]}] BACKPORT--> Co-authored-by: Sid <[email protected]>
kibanamachine
referenced
this issue
Sep 27, 2024
…eader (#194196) (#194283) # Backport This will backport the following commits from `main` to `8.x`: - [[Roles] Fix bug with roles grid not sorting on clicking table header (#194196)](#194196) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sid","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-27T10:59:28Z","message":"[Roles] Fix bug with roles grid not sorting on clicking table header (#194196)\n\nFixes https://github.com/elastic/kibana/issues/193786\r\n\r\n## Summary\r\nReverts a few changes made when the Roles grid page was moved to a\r\nfunctional component. Fixes regression in table sorting.\r\n\r\n### Notes\r\n\r\nWhen preparing for the Query Roles API, we had moved the roles grid page\r\nto be a functional component. In doing so, we also migrated away from\r\nthe In Memory table in favor of the basic table. EUIBasicTable does not\r\nsupport sorting out of the box and is meant to be used for server-side\r\nsorting, etc (unless we implement custom sorting logic). I've made a few\r\nchanges:\r\n- Bring back the InMemoryTable but keep the Search Bar.\r\n- Remove few (now) unused functions which are to be brought back\r\nwhenever the Query Roles API is ready.\r\n- Update tests\r\n\r\n### Screen recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4ac4f771-e7d1-4e17-807e-d6262767d100\r\n\r\n\r\n\r\n### Release notes\r\nFixes UI regression in Roles listing page where users could not sort\r\ntable by using the headers.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f4ca9e4730ee6b13d19808be9fcc633dce9087d5","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","regression","release_note:fix","Team:Security","Feature:Users/Roles/API Keys","v9.0.0","backport:prev-major"],"title":"[Roles] Fix bug with roles grid not sorting on clicking table header","number":194196,"url":"https://github.com/elastic/kibana/pull/194196","mergeCommit":{"message":"[Roles] Fix bug with roles grid not sorting on clicking table header (#194196)\n\nFixes https://github.com/elastic/kibana/issues/193786\r\n\r\n## Summary\r\nReverts a few changes made when the Roles grid page was moved to a\r\nfunctional component. Fixes regression in table sorting.\r\n\r\n### Notes\r\n\r\nWhen preparing for the Query Roles API, we had moved the roles grid page\r\nto be a functional component. In doing so, we also migrated away from\r\nthe In Memory table in favor of the basic table. EUIBasicTable does not\r\nsupport sorting out of the box and is meant to be used for server-side\r\nsorting, etc (unless we implement custom sorting logic). I've made a few\r\nchanges:\r\n- Bring back the InMemoryTable but keep the Search Bar.\r\n- Remove few (now) unused functions which are to be brought back\r\nwhenever the Query Roles API is ready.\r\n- Update tests\r\n\r\n### Screen recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4ac4f771-e7d1-4e17-807e-d6262767d100\r\n\r\n\r\n\r\n### Release notes\r\nFixes UI regression in Roles listing page where users could not sort\r\ntable by using the headers.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f4ca9e4730ee6b13d19808be9fcc633dce9087d5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194196","number":194196,"mergeCommit":{"message":"[Roles] Fix bug with roles grid not sorting on clicking table header (#194196)\n\nFixes https://github.com/elastic/kibana/issues/193786\r\n\r\n## Summary\r\nReverts a few changes made when the Roles grid page was moved to a\r\nfunctional component. Fixes regression in table sorting.\r\n\r\n### Notes\r\n\r\nWhen preparing for the Query Roles API, we had moved the roles grid page\r\nto be a functional component. In doing so, we also migrated away from\r\nthe In Memory table in favor of the basic table. EUIBasicTable does not\r\nsupport sorting out of the box and is meant to be used for server-side\r\nsorting, etc (unless we implement custom sorting logic). I've made a few\r\nchanges:\r\n- Bring back the InMemoryTable but keep the Search Bar.\r\n- Remove few (now) unused functions which are to be brought back\r\nwhenever the Query Roles API is ready.\r\n- Update tests\r\n\r\n### Screen recording\r\n\r\n\r\nhttps://github.com/user-attachments/assets/4ac4f771-e7d1-4e17-807e-d6262767d100\r\n\r\n\r\n\r\n### Release notes\r\nFixes UI regression in Roles listing page where users could not sort\r\ntable by using the headers.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"f4ca9e4730ee6b13d19808be9fcc633dce9087d5"}}]}] BACKPORT--> Co-authored-by: Sid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version: main
Describe the bug:
The Roles grid does not sort anymore
Steps to reproduce:
Expected behavior:
The columns should sort in some fashion, but it doesn't do anything.
Screenshots (if relevant):
The text was updated successfully, but these errors were encountered: