[ResponseOps][Alerts] Add fallback value for alert filter controls panels #193745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbopepato
added
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
umbopepato
added
release_note:fix
backport:prev-major
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
| @@ -17,7 +17,7 @@ import { isEmpty, isEqual, pick } from 'lodash'; | |||
| import type { FilterControlConfig } from './types'; | |||
|
|
|||
| export const getPanelsInOrderFromControlsState = (controlState: ControlGroupRuntimeState) => { | |||
| const panels = controlState.initialChildControlState; | |||
| const panels = controlState.initialChildControlState ?? {}; | |||
There was a problem hiding this comment.
It would be nice to have some tests for the util.
|
Closing in favor of #194785 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a fallback value for the alert filter controls bar's
panelsconfiguration when it's undefined.Fixes #193565