[Bug][Security Solution] - Unable to pin event with existing note #193738
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
Team:Threat Hunting:Investigations
Security Solution Investigations Team
Milestone
Comments
michaelolo24
added
bug
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
1 task
christineweng
added a commit
that referenced
this issue
Oct 4, 2024
…194473) ## Summary Fixed some pinning behaviors in new notes system, namely: - Pinning is greyed out only when an event has a note attached to the **current** timeline, else pinning should work as usual (related: #193738) - Adding a note and attaching to current timeline automatically pins the event - Pinned tab and pinning capability are updated when a note attached to current timeline is deleted Feature flag: `securitySolutionNotesEnabled` https://github.com/user-attachments/assets/0163d4a4-354c-4928-a337-40a93f6c7b2a ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 4, 2024
…lastic#194473) ## Summary Fixed some pinning behaviors in new notes system, namely: - Pinning is greyed out only when an event has a note attached to the **current** timeline, else pinning should work as usual (related: elastic#193738) - Adding a note and attaching to current timeline automatically pins the event - Pinned tab and pinning capability are updated when a note attached to current timeline is deleted Feature flag: `securitySolutionNotesEnabled` https://github.com/user-attachments/assets/0163d4a4-354c-4928-a337-40a93f6c7b2a ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 883dfa8)
kibanamachine
added a commit
that referenced
this issue
Oct 4, 2024
…otes (#194473) (#194890) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Notes] - fix pinning behavior in document notes (#194473)](#194473) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-04T00:42:26Z","message":"[Security Solution][Notes] - fix pinning behavior in document notes (#194473)\n\n## Summary\r\n\r\nFixed some pinning behaviors in new notes system, namely:\r\n\r\n- Pinning is greyed out only when an event has a note attached to the\r\n**current** timeline, else pinning should work as usual (related:\r\nhttps://github.com//issues/193738)\r\n- Adding a note and attaching to current timeline automatically pins the\r\nevent\r\n- Pinned tab and pinning capability are updated when a note attached to\r\ncurrent timeline is deleted\r\n\r\nFeature flag: `securitySolutionNotesEnabled`\r\n\r\n\r\nhttps://github.com/user-attachments/assets/0163d4a4-354c-4928-a337-40a93f6c7b2a\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"883dfa8ae887c1ee57049a45d8ed8ceb7c2a34d6","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Investigations","backport:prev-minor","v8.16.0"],"title":"[Security Solution][Notes] - fix pinning behavior in document notes","number":194473,"url":"https://github.com/elastic/kibana/pull/194473","mergeCommit":{"message":"[Security Solution][Notes] - fix pinning behavior in document notes (#194473)\n\n## Summary\r\n\r\nFixed some pinning behaviors in new notes system, namely:\r\n\r\n- Pinning is greyed out only when an event has a note attached to the\r\n**current** timeline, else pinning should work as usual (related:\r\nhttps://github.com//issues/193738)\r\n- Adding a note and attaching to current timeline automatically pins the\r\nevent\r\n- Pinned tab and pinning capability are updated when a note attached to\r\ncurrent timeline is deleted\r\n\r\nFeature flag: `securitySolutionNotesEnabled`\r\n\r\n\r\nhttps://github.com/user-attachments/assets/0163d4a4-354c-4928-a337-40a93f6c7b2a\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"883dfa8ae887c1ee57049a45d8ed8ceb7c2a34d6"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194473","number":194473,"mergeCommit":{"message":"[Security Solution][Notes] - fix pinning behavior in document notes (#194473)\n\n## Summary\r\n\r\nFixed some pinning behaviors in new notes system, namely:\r\n\r\n- Pinning is greyed out only when an event has a note attached to the\r\n**current** timeline, else pinning should work as usual (related:\r\nhttps://github.com//issues/193738)\r\n- Adding a note and attaching to current timeline automatically pins the\r\nevent\r\n- Pinned tab and pinning capability are updated when a note attached to\r\ncurrent timeline is deleted\r\n\r\nFeature flag: `securitySolutionNotesEnabled`\r\n\r\n\r\nhttps://github.com/user-attachments/assets/0163d4a4-354c-4928-a337-40a93f6c7b2a\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"883dfa8ae887c1ee57049a45d8ed8ceb7c2a34d6"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <[email protected]>
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this issue
Oct 7, 2024
…lastic#194473) ## Summary Fixed some pinning behaviors in new notes system, namely: - Pinning is greyed out only when an event has a note attached to the **current** timeline, else pinning should work as usual (related: elastic#193738) - Adding a note and attaching to current timeline automatically pins the event - Pinned tab and pinning capability are updated when a note attached to current timeline is deleted Feature flag: `securitySolutionNotesEnabled` https://github.com/user-attachments/assets/0163d4a4-354c-4928-a337-40a93f6c7b2a ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On current main, when a user adds a note to an event without attaching it to a timeline, that event can no longer be pinned in timeline as timeline registers it as pinned because of the note.
The text was updated successfully, but these errors were encountered: