Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Update function metadata #193662

Merged
merged 3 commits into from
Sep 23, 2024
Merged

[ES|QL] Update function metadata #193662

merged 3 commits into from
Sep 23, 2024

Conversation

kibanamachine
Copy link
Contributor

@kibanamachine kibanamachine commented Sep 23, 2024 •
edited
Loading

This PR updates the function definitions and inline docs based on the latest metadata from Elasticsearch.

@kibanamachine kibanamachine requested a review from a team as a code owner September 23, 2024 04:15
@kibanamachine kibanamachine added release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana labels Sep 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula
Copy link
Contributor

/ci

@stratoula stratoula added Feature:ES|QL ES|QL related features in Kibana backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Sep 23, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 172.9KB 174.3KB +1.4KB
securitySolution 20.4MB 20.4MB +1.5KB
unifiedSearch 341.6KB 342.9KB +1.4KB
total +4.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.4MB 3.4MB +1.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit e78ba89 into main Sep 23, 2024
20 checks passed
@stratoula stratoula deleted the esql_generate_function_metadata_1727064908 branch September 23, 2024 10:00
@kibanamachine
Copy link
Contributor Author

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [[ES

Manual backport

To create the backport manually run:

node scripts/backport --pr 193662

Questions ?

Please refer to the Backport tool documentation

weizijun added a commit to weizijun/kibana that referenced this pull request Sep 23, 2024
@weizijun
Merge branch 'main' into add-alibaba-inference
2100828 
* main: (176 commits)
  [ML][Rules] Fixes deletion in Check interval input for anomaly detection rule (elastic#193420)
  Bump maximum supported package spec version to 3.2 (elastic#193574)
  [ES|QL] new pattern for `SORT` autocomplete (elastic#193595)
  [Inventory][ECO] Entities page search bar (elastic#193546)
  [Synthetics] Remove extra overview route (elastic#192449)
  [Obs Alerts table] Fix error on clicking alert reason message (elastic#193693)
  [Migrations] Remove tests that are not applicable in 9.x (elastic#193699)
  [EDR Workflows] Set Agent Tamper Protection to false on policy unassignment (elastic#193017)
  [Inventory][ECO] Enable elastic entity model from inventory (elastic#193557)
  [EDR Workflows] The host isolation exception tab is hidden on the basic license if no artifacts (elastic#192562)
  [Entity Analytics] Ensuring definition transforms are managed (elastic#193408)
  [Automatic Import] Do not remove message field for unstructured logs (elastic#193678)
  [Fleet] Add missing permissions for connector package (elastic#193573)
  [Fleet] using @kbn/config-schema part 2 (outputs and other apis)  (elastic#193326)
  [Migrations] Provide testing archives + tooling for migrations integration tests (elastic#193328)
  [ES|QL] Renames the textbased editor to esql editor (elastic#193521)
  [ES|QL] Update function metadata (elastic#193662)
  [Security Solution][Entity Analytics] Scoping the entity store to spaces (elastic#193303)
  [Docs] Update Sharing docs (elastic#190318)
  [ML] AIOps: Move Log Rate Analysis results callout to help popover. (elastic#192243)
  ...

# Conflicts:
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.test.tsx
#	x-pack/plugins/search_inference_endpoints/public/components/all_inference_endpoints/render_table_columns/render_endpoint/endpoint_info.tsx
@drewdaemon
Copy link
Contributor

Actually, I think CATEGORIZE is another grouping function. We currently maintain those manually so I will follow up with a PR to exclude it from the list.

@kibanamachine
Copy link
Contributor Author

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 193662 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2024
@kibanamachine
Copy link
Contributor Author

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 193662 locally

@stratoula stratoula mentioned this pull request Oct 1, 2024
Merged
@stratoula
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

stratoula pushed a commit to stratoula/kibana that referenced this pull request Oct 1, 2024
@kibanamachine
[ES|QL] Update function metadata (elastic#193662)
5eca94e 
This PR updates the function definitions and inline docs based on the
latest metadata from Elasticsearch.

Co-authored-by: Stratoula Kalafateli <[email protected]>
(cherry picked from commit e78ba89)
stratoula added a commit that referenced this pull request Oct 1, 2024
@stratoula @kibanamachine
[8.x] [ES|QL] Update function metadata (#193662) (#194524)
077537c 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Update function metadata
(#193662)](#193662)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kibana
Machine","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T10:00:34Z","message":"[ES|QL]
Update function metadata (#193662)\n\nThis PR updates the function
definitions and inline docs based on the\r\nlatest metadata from
Elasticsearch.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<[email protected]>","sha":"e78ba89cc24c744ccd6137e4d53b10e104f2bd96","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL"],"number":193662,"url":"https://github.com/elastic/kibana/pull/193662","mergeCommit":{"message":"[ES|QL]
Update function metadata (#193662)\n\nThis PR updates the function
definitions and inline docs based on the\r\nlatest metadata from
Elasticsearch.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<[email protected]>","sha":"e78ba89cc24c744ccd6137e4d53b10e104f2bd96"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193662","number":193662,"mergeCommit":{"message":"[ES|QL]
Update function metadata (#193662)\n\nThis PR updates the function
definitions and inline docs based on the\r\nlatest metadata from
Elasticsearch.\r\n\r\nCo-authored-by: Stratoula Kalafateli
<[email protected]>","sha":"e78ba89cc24c744ccd6137e4d53b10e104f2bd96"}}]}]
BACKPORT-->

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine added v8.16.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kibanamachine @elasticmachine @stratoula @kibana-ci @drewdaemon