[Search][Onboarding] Index Details - No Data view #193637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TattdCodeMonkey
added
release_note:skip
TattdCodeMonkey
changed the title
TattdCodeMonkey
force-pushed
the
search-indices/index-details-no-data
branch
from
6c6e187 to
ddda82c
Compare
joemcelroy
reviewed
Sep 23, 2024
| const indexHasMappings = Object.keys(mappingProperties).length > 0; | ||
|
|
||
| // TODO: initing this should be dynamic and possibly saved in the form state | ||
| const [selectedLanguage, setSelectedLanguage] = useState<AvailableLanguages>('python'); |
There was a problem hiding this comment.
I wonder if for now we store this option in localstorage and have a hook so the selected language is consistent everywhere.
Ideally i would love a user preference for this that also part of the dev console code exporter too.
There was a problem hiding this comment.
I want to say the dev console is doing this, let me check where they are storing that and maybe we use that.
The bigger difference will be they have an explicit "set as default" option, so I'm not 100% sure if we'd want to update that value if we change it here. But if that value is set we could default to the same language?
Either way I want to write a utility function for find the default language and we can iterate on the logic for that.
There was a problem hiding this comment.
yep - I think the bigger issue if we do nothing is that create-index selected option could be different from the search-detail and feel like a bug so having a utility function to find the selected language (whether default or user selected) makes sense and we can iterate to have more awareness of dev-console preferences.
joemcelroy
approved these changes
Sep 23, 2024
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6999[✅] x-pack/test_serverless/functional/test_suites/search/config.feature_flags.ts: 25/25 tests passed. |
TattdCodeMonkey
force-pushed
the
search-indices/index-details-no-data
branch
from
bad9588 to
4389368
Compare
TattdCodeMonkey
force-pushed
the
search-indices/index-details-no-data
branch
from
4389368 to
3decca2
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 25, 2024
## Summary Introduction of the No Data view for the index details Data tab. ### Screenshots Index without data or mapping  Index with mappings but no Data  ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) (cherry picked from commit 0be74e9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 25, 2024
…94023) # Backport This will backport the following commits from `main` to `8.x`: - [[Search][Onboarding] Index Details - No Data view (#193637)](#193637) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-25T14:40:15Z","message":"[Search][Onboarding] Index Details - No Data view (#193637)\n\n## Summary\r\n\r\nIntroduction of the No Data view for the index details Data tab.\r\n\r\n### Screenshots\r\nIndex without data or mapping\r\n\r\n\r\n\r\nIndex with mappings but no Data\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"0be74e9364134362f3e9a8064a94a5a744bea4fb","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"[Search][Onboarding] Index Details - No Data view","number":193637,"url":"https://github.com/elastic/kibana/pull/193637","mergeCommit":{"message":"[Search][Onboarding] Index Details - No Data view (#193637)\n\n## Summary\r\n\r\nIntroduction of the No Data view for the index details Data tab.\r\n\r\n### Screenshots\r\nIndex without data or mapping\r\n\r\n\r\n\r\nIndex with mappings but no Data\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"0be74e9364134362f3e9a8064a94a5a744bea4fb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193637","number":193637,"mergeCommit":{"message":"[Search][Onboarding] Index Details - No Data view (#193637)\n\n## Summary\r\n\r\nIntroduction of the No Data view for the index details Data tab.\r\n\r\n### Screenshots\r\nIndex without data or mapping\r\n\r\n\r\n\r\nIndex with mappings but no Data\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))","sha":"0be74e9364134362f3e9a8064a94a5a744bea4fb"}}]}] BACKPORT--> Co-authored-by: Rodney Norris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduction of the No Data view for the index details Data tab.
Screenshots
Index without data or mapping
Index with mappings but no Data
Checklist