Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] [Controls] Controls overwritten on navigation #193611

Closed
Heenawter opened this issue Sep 20, 2024 · 2 comments
Closed

[Dashboard] [Controls] Controls overwritten on navigation #193611

Heenawter opened this issue Sep 20, 2024 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort project:embeddableRebuild regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Heenawter commented Sep 20, 2024 •
edited
Loading

Describe the bug:
This is the bug that just keeps on giving. Unfortunately, I think we reintroduced it with either (1) the control group + dashboard integration or (2) the start of the dashboard refactor.

Steps to reproduce:

  1. Create a dashboard with controls with either a links panel or a markdown link to another dashboard
  2. Try navigating
  3. Notice that controls get replaced in the destination dashboard with the controls from the source dashboard 🔥

Expected behavior:
The controls should get updated to the controls from the destination dashboard

Screenshots (if relevant):

Screen.Recording.2024-09-20.at.9.34.37.AM.mov

Any additional context:
I honestly think it might just be an update issue - hence the LOE. It doesn't look like the control group re-renders at all after navigation. We need to tie the control group renderer to update when the dashboard ID changes.
@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Sep 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter added loe:small Small Level of Effort regression and removed loe:medium Medium Level of Effort labels Sep 20, 2024
@Heenawter
Copy link
Contributor Author

Closing oops - I was running the #193220 PR locally and turns out it's from there. This isn't on main yet. Phew! 😆

@Heenawter Heenawter closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2024
@Heenawter Heenawter mentioned this issue Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort project:embeddableRebuild regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Heenawter @elasticmachine