Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Improve handling of invalid requests #193582

Open
yuliacech opened this issue Sep 20, 2024 · 2 comments
Open

[Console] Improve handling of invalid requests #193582

yuliacech opened this issue Sep 20, 2024 · 2 comments
Assignees
@mattkime
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@yuliacech
Copy link
Contributor

Currently, when a request is invalid, the parser only contains information about the start of the request and the logic in requests_utils.ts (see this line) computes the line number where the invalid request should end. When there are comments following an invalid request, they are highlighted together with the request because the end line is detected incorrectly.

Screenshot

Image
@yuliacech yuliacech added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Sep 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@alisonelizabeth alisonelizabeth added the bug Fixes for quality problems that affect the customer experience label Sep 23, 2024
@sabarasaba sabarasaba mentioned this issue Dec 5, 2024
Open
@alisonelizabeth
Copy link
Contributor

@mattkime can you pick this one up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkime mattkime

Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mattkime @sabarasaba @alisonelizabeth @yuliacech @elasticmachine